gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
41,021 Commits 39 Branches 720 Tags 6 GiB
Commit Graph

24 Commits

Author SHA1 Message Date
Jonathan Druart d8e3ad15b7 Bug 7806: Fix remaining occurrences of 0000-00-00 
We should remove all SQL queries that contain 0000-00-00 and finally
assume we do not longer have such value in our DB (for date type)

We already dealt with such values in previous update DB entries.
The 2 added by this one haven't been replaced already.

The code will now assume that either a valid date exist, or NULL/undef.

Test plan:
QA review is needed and test of the different places where code is
modified.

Not sure about the change from reports/issues_avg_stats.pl

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 099e2fe2b7)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
 2021-03-04 10:24:48 +01:00
Owen Leonard 31eb8196ed Bug 25354: Clean up JavaScript markup in cataloging plugin scripts 
This patch makes some minor changes to the JavaScript generated by the
cataloging plugins: <script> "type" attribute removed; single-line
comments converted to multi-line style; obsolete //<![CDATA[ marks
removed.

These changes help the JavaScript conform to current coding guidelines.
The comment style change allows for whitespace in the scripts to be
collapsed by the Template::Toolkit "collapse" filter.

Since the patch makes small cosmetic changes to many files it may be
easiest to test this patch by visually inspecting the changes.

It's also simple to test some plugins which are enabled by default (at
least in MARC21): In the basic MARC editor, the leader, 007, and 008. In
the item editor, subfield d - Date acquired.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
 2020-10-14 14:50:07 +02:00
Owen Leonard 61ca2359f2
Bug 11500: Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) 
This patch modifies the cataloging plugin dateaccessioned.pl so that it
triggers the addition of a datepicker widget to fields it is linked
with. Despite its name the plugin can be used on any item field which
requires a date.

To test, apply the patch and make sure you have one or more item
subfields linked to the dateaccessioned.pl plugin. For instance, in
MARC21:

 - Administration -> MARC bibliographic framework -> MARC structure ->
   952 -> Edit subfields:
   - subfields d ("Date acquired") and w ("Price effective from"):
     - Other options -> Plugin -> dateaccessioned.pl

 - Go to cataloging and add or edit an item on a bibliographic record
 - The "Date acquired" and "Price effective from" fields should be
   styled as datepickers.
 - Clicking in these fields should populate the field with today's date
   and trigger the datepicker popup.
 - Test that all the datepicker features work correctly.
 - Test that manual entry of a date works.

 - With the AcqCreateItem system preference set to "placing an order,"
   go to Acquisitions -> Vendor -> Add to basket.
   - Add a title to your basket using your preferred method.
   - In the "New order" form, find the section for adding an item.
   - Test the "Date acquired" and "Price effective from" fields, which
     should behave just like they did in the cataloging module.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
 2019-12-23 12:01:45 +00:00
Josef Moravec 68fbc96218 Bug 22127: Update date accessioned plugin - remove unused routine 
Test plan:
1) Apply the patch
2) Have set dateaccessioned plugin to an item subfield (it is set on 952$d by default)
3) Confirm the functionality of this plugin is same as before patch

Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
 2019-03-29 11:28:39 +00:00
Owen Leonard 0c4d23a193 Bug 19595: Clicking plugin link does not fill item's date acquired field 
This patch updates the dateaccessioned plugin for the item edit form to
return functionality which was removed in a previous patch.

To test, apply the patch and open an item for editing. Clicking the
"..." link next to the "Date acquired" field should insert the current
date, overwriting the existing date.

Open a blank item add form. Putting the cursor in the "Date acquired"
field should automatically insert the current date.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Added a comment line in set_to_today.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
 2017-12-07 10:09:51 -03:00
Marcel de Rooy b133b0e94d Bug 16203: Convert item plugins to new style (see bug 10480) 
Converts item plugins to new style (with builder and launcher).
See also bugs 10480 and 13437.

The following plugins have been adjusted:
barcode_manual.pl
barcode.pl
callnumber-KU.pl
callnumber.pl
cn_browser.pl (Added license statement too)
dateaccessioned.pl
macles.pl
stocknumberam123.pl
stocknumberAV.pl
stocknumber.pl

Test plan:
Connect the plugin to an item field.
Verify that the plugin still works.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested if all plugins compile okay.
Ran most of them thru FrameworkPlugin.t.
Tested them in the item editor.

Note: the form for macles.pl comes up, further hard to test.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
 2016-12-16 11:55:27 +00:00
Marc Véron 5dceb851dd Bug 13813: Remove deprecated module C4::Dates from system 
Test plan: See Bugzilla.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
 2015-09-18 12:40:55 -03:00
Jonathan Druart a6c9bd0eb5 Bug 9978: Replace license header with the correct license (GPLv3+) 
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

http://bugs.koha-community.org/show_bug.cgi?id=9987

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
 2015-04-20 09:59:38 -03:00
Marcel de Rooy 0d177c9546 Bug 10480: Remove useless routines and irrelevant pod lines 
This patch makes the following cleanup actions for all plugins:

1- Remove sub plugin_parameters. This function is not used.
2- Remove empty plugin or empty plugin_javascript subs.
3- Remove empty Blur, Clic or Focus routines from javascript.
4- Remove pod lines (copy-pasta) only referring to the 3 plugin subs.
5- Remove the last 1; line. It is no longer needed.

Test plan:
Run the unit test t/db_dependent/FrameworkPlugins.t
Test some cataloguing plugins in addbiblio.
Test some item plugins in additem and neworderempty.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
I also checked the syntax of all plugins with perl -c.
And checked the pod (if any) with podchecker: Two files still produce a
warning; the follow-up deals with them: unimarc_field_686a/_700-4.pl.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
 2015-04-16 14:48:40 -03:00
Jonathan Druart 8dfc399a2d Bug 12884: Get rid of redefined subroutine warnings in dateaccessioned.pl 
Instead of removing all warnings, we should remove warnings about the
redefined subroutines.

Test plan:
- link the dateaccessioned plugin with one of your biblio field
- edit an item
- verify they are no warnings in the Koha log file.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
 2014-10-22 14:18:40 -03:00
Adrien Saurat 8ca93323fe Bug 6125: repairs dateaccessioned plugin 
1/ It now works with neworderempty.pl
2/ The set_to_today function was moved from
additem.tt to dateaccessioned.pl (so it's
available to all pages using the plugin)

Signed-off-by: Julien Sicot <julien.sicot@gmail.com>

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
 2012-03-22 16:18:38 +01:00
Chris Cormack e8ea58270d Bug 6679 : Not using strict .. bad script, no cookie for you! 
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
 2011-11-06 18:13:33 +01:00
Andrew Elwell 9fa574f609 Bug 5385: POD Cleanups (part 1) 
working through the master branch to eliminate all
podchecker warnings/errors

Actual improvement to the quality of the POD will
come later (hopefully with assistance of others)

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
 2010-11-12 10:06:55 +13:00
Donovan Jones f394170ebc Bug 2505 - Add commented use warnings where missing in the cataloguing/ directory 2010-04-21 20:27:05 +12:00
Lars Wirzenius 5c42b6512e Fix FSF address in directory cataloguing/ 
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
 2010-03-16 20:17:55 -04:00
Joe Atzberger ce760ba9e8 Bug 2919 -- fix value_builder plugins for dateaccessioned, barcode 
This patch depends on my previous one "Begin cleanup on additem" and
fixes one bug introduced in that patch.

Overhaul of additem sections to factor out common pieces especially attributes.
Plugin js vastly simplified and reimplemented in jquery.  Performance improved.

Note that a particularly busy cataloging department should still leave
barcode blank for server-side autopopulation to avoid collision.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
 2009-04-08 14:00:13 -05:00
Chris Nighswonger f185d69ad2 kohabug 2955 (2/2) GetMarcFromKohaField now requires $framework 
Failure to pass the $framework parameter by dateaccessioned.pl causes
GetMarcFromKohaField to return 0,0 which breaks the value builder. The
patch
submitted corrects this.

This patch is build against the current 3.1.x HEAD, however, this bug
also
affects the 3.0.x codebase and should be applied there as well.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
 2009-02-12 14:46:28 -06:00
Galen Charlton 4bf76c2d77 bug 2615: remove unneeded 'require Exporter' 
Most Perl scripts (as opposed to modules) do
not need to require Exporter.

No user-visible or documentation changes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
 2008-09-26 09:05:08 -05:00
Owen Leonard 5d640ddbb2 Fixing typo in value_builder/dateaccessioned.pl; Adding error message output to additem.tmpl (fixes Bug 1636, Can't delete from additems.pl). 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-12-12 08:05:38 -06:00
Owen Leonard 7732454bf7 Fixing typo in value_builder/dateaccessioned.pl; Adding error message output to additem.tmpl (fixes Bug 1636, Can't delete from additems.pl). 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-12-04 17:56:24 -06:00
Joshua Ferraro 60f37d1aff adding back CDATA for validation 2007-12-04 17:25:47 -06:00
Joshua Ferraro 75a2023bd6 fixing dateaccessioned plugin 2007-12-04 13:44:31 -06:00
Galen Charlton 1dd1934221 fix minor XHTML validation issues 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-12-04 09:50:03 -06:00
Joshua Ferraro 2131e1e9aa adding dateaccessioned plugin 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-06 01:38:49 -05:00