Commit Graph

298 Commits

Author SHA1 Message Date
Lucas Gass 0ce80f808e RMaint Follow up fixing mistake of not running DBIC after DBRev
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2019-09-19 21:11:43 +00:00
Lucas Gass ef94f8e190 Bug 23151: RMaint Follow up
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2019-09-19 20:47:26 +00:00
Lucas Gass 9c1720d7d7 Bug 23309: RMaint Follow up
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2019-09-19 20:35:43 +00:00
Mark Tompsett feaf19c992 Bug 23151: Schema changes
It is best to regenerate these from scratch.
On a kohadevbox:
$ misc/devel/update_dbix_class_files.pl --db_name=koha_kohadev --db_user=koha_kohadev --db_passwd=password

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 1af2698b84)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 7c0a88f9e1)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2019-07-22 23:57:51 +00:00
Nick Clemens 41971fd6da
Bug 22899: DBRev 18.11.05.001
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit b90bbc1259)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2019-05-24 14:40:40 +01:00
Nick Clemens cd147f78d7
Bug 22782: DBIC update for SocialData
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 5ecbe281af)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2019-05-17 14:29:25 +01:00
Tomas Cohen Arazi 34dba63bfe
Bug 13895: (QA follow-up) Adjust OpenAPI definitions for checkouts
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit b63fd774c1)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2019-04-01 15:01:58 +01:00
Nick Clemens de1690a442
Bug 21846: Update Schema
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 6757591297)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2019-03-19 10:43:12 +00:00
Nick Clemens eae99688ac
Bug 13515: DBRev 18.11.03.001
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 2c6d39452a)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2019-02-25 12:26:52 +00:00
Tomas Cohen Arazi 92cd2f8ca6
Bug 22125: branches.pickup_location should be flagged as boolean
This trivial patch just marks the mentioned column as a boolean.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

https://bugs.koha-community.org/show_bug.cgi?id=16497

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 95ce61fd3e)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2019-01-31 16:15:04 +00:00
Nick Clemens 852be591db
Bug 21065: DBRev 18.11.00.002
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 5ea668056a)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-12-20 09:34:47 +00:00
Jonathan Druart f899e44014
Bug 21065: Add koha_object(s)_class methods to accountline
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 457e560a06)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-12-20 09:29:24 +00:00
Nick Clemens 51a1a465c8
Bug 21896: RM follow-up - fix tests
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit b4580bff5b)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-12-10 09:58:36 +00:00
Martin Renvoize eba382d9c1
Bug 21896: (QA follow-up) Document and Test for FIFO behaviour
A short dicussion lead to the decision to make it explictly clear that
this method will implicitly apply credits against debits in a 'First In
First Out' manor, meaning oldest outstanding debits will be paid off
first.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 99535e0fda)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-12-10 09:55:46 +00:00
Nick Clemens fb5dd4c942 Bug 15836: DBRev 18.06.00.060
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-11-13 16:21:22 +00:00
Nick Clemens d013562745 Bug 12365: (RM follow-up) Fix schema files
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-11-08 18:14:24 +00:00
Aleisha Amohia 812b3d66b5 Bug 12365: Notes for rules
This patch adds a note column to the circ and fine rules to act as a
description line for the rule.

To test:
1) Apply patch, update database (may have to also update schema)
2) Go to Admin -> Circ and fine rules
3) Scroll to the right, notice new Note column
4) Confirm it works to create a brand new rule with a Note
5) Confirm it works to modify an existing rule with a Note

Sponsored-by: Catalyst IT

Lee Jamison <ldjamison@marywood.edu> rescued this patch.
It is a clean re-build of attachments 61865 and 63902
to fix the merge conflict introduced during application of both
attachments.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: macon  lauren KohaCon17 <caballeromaricon@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-11-08 11:43:11 +00:00
Nick Clemens 07526d897a Bug 18316: DBRev 18.06.00.054
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-11-07 23:11:51 +00:00
Nick Clemens cda457c6f2 Bug 18591: Add missing schema file
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-10-27 15:03:03 +00:00
Nick Clemens 4d8ac89c0e Bug 18591: DBRev 18.06.00.046
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-10-27 13:21:09 +00:00
Nick Clemens 2e3eb44319 Bug 15766: (RM follow-up) Schema updates
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-10-24 17:35:18 +00:00
Nick Clemens 0c4ed27244 Bug 15486: DBRev 18.06.00.043
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-10-24 13:24:06 +00:00
Tomas Cohen Arazi 511ffe4700 Bug 20772: (QA follow-up) 'readonly' is a boolean
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2018-10-13 08:34:33 -03:00
Tomas Cohen Arazi 3516e9a9f8 Bug 20772: DBRev 18.06.00.041
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2018-10-13 08:34:33 -03:00
Martin Renvoize 06e4af6ba8 Bug 11897: Add Boolean handling to dbic classes.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-10-09 15:53:27 +00:00
Alex Sassmannshausen d87bffa091 Bug 11897: DBIX::Class::Ordered in Stockrotationstage.
* Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add
  grouping_column.

Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-10-09 15:53:14 +00:00
Nick Clemens 2f2e40ca46 Bug 11897: DBRev 18.06.00.040
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-10-09 15:51:34 +00:00
Nick Clemens cf8890465d Bug 21417: DBRev 18.06.00.038
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-10-09 12:57:29 +00:00
Nick Clemens 91790fdd90 Bug 21082: DBRev 18.06.00.037
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-10-09 11:04:23 +00:00
Nick Clemens 2cb8e9755a Bug 18887: DBRev 18.06.00.036
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-10-05 14:49:13 +00:00
Jonathan Druart b3dee0daf2 Bug 21385: Define the Koha object class for orders
It fixes the following issue:
t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t .. 1/40 Can't
locate object method "_new_from_dbic" via package "Koha::Aqorder"
(perhaps you forgot to load "Koha::Aqorder"?) at
/home/vagrant/kohaclone/Koha/Object.pm line 230.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-10-01 23:57:18 +00:00
Nick Clemens b5becc84f5 Bug 5458: DBRev 18.06.00.032
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-09-26 16:17:06 +00:00
Nick Clemens 3dda7d6c7f Bug 20819: DBRev 18.06.00.031
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-09-20 13:45:27 +00:00
Tomas Cohen Arazi b64f1808f1 Bug 20777: DBIC update
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-09-15 21:44:33 +00:00
Jonathan Druart 6a2a80988d Bug 21235: Remove table services_throttle
This table was only used by XISBN, this patch remove the table and the
related code (cronjobs)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

https://bugs.koha-community.org/show_bug.cgi?id=21235
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-09-07 15:09:39 +00:00
Nick Clemens f190ef3f2e Bug 7534: DBRev 18.06.00.024
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-09-06 17:32:27 +00:00
Nick Clemens 092d52d5cf Bug 18639: DBRev 18.06.00.023
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-08-31 12:46:52 +00:00
Nick Clemens 4a2bdc80ab Bug 21068: (RM follow-up) Schema updates
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-08-30 16:10:09 +00:00
Nick Clemens f15e9bfd14 Bug 15524: (RM follow-up) Update schema files
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-08-25 19:06:39 +00:00
Nick Clemens 1ea7d9790d Bug 17698: DBRev 18.06.00.011
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-07-23 15:34:12 +00:00
Nick Clemens 574cc2f787 Bug 19166: DBRev 18.06.00.009
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-07-19 17:33:55 +00:00
Nick Clemens 7d7cd25f4c Bug 19166: (follow-up) Adjust table and files and QA issues
Move to aqinvoice_adjustment
Move to Koha::Acquisition::Invoice::Adjustments
Test if variable exists before count

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-07-19 17:28:41 +00:00
Nick Clemens dcf207170b Bug 19524: DBRev 18.06.006
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-07-18 16:55:56 +00:00
Jonathan Druart 1144ee4b81 Bug 20287: Koha::Object->get_from_storage
May be part of a separate bug report if needed

TODO - add POD + tests

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-07-18 15:49:45 +00:00
Nick Clemens fba0648384 Bug 12395: DBRev 18.06.00.005
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-07-06 14:19:22 +00:00
Nick Clemens 487e4708b3 Bug 20073: (RM follow-up) Update schema files 2018-06-27 04:17:06 +00:00
Jonathan Druart 117e3a18f5 Bug 20934: Fix display of old checkouts in the checkout history page
Again a regression caused by
  commit fa54100dff
  Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory]

GetBiblioIssues does a union all with issues and old_issues, so we
should old_issues as well.
To make the join on the items table we need to define the item and
patron methods. For consistency the relationships have been redefined
(item instead of itemnumber, borrower instead of borrowernumber) in the
DBIx::Class definition.

This is not perfect but I think the best way to provide an easy to
backport patch.

It highlights that we need improvements in this area.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
The patch works as expected.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-06-22 12:47:48 +00:00
Jonathan Druart ad96a900f2 Revert "Bug 20073: Update DBIC Schema changes"
This reverts commit dc300b6547.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2018-05-24 14:30:21 -03:00
Jonathan Druart dc300b6547 Bug 20073: Update DBIC Schema changes
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2018-05-09 12:56:03 -03:00
Tomas Cohen Arazi 28a750fb76 Bug 20568: (QA follow-up) Get rid of the id column
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2018-05-09 12:55:59 -03:00