From fbdd6470fb6afddf461411ff608e9523558351f9 Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Thu, 23 Apr 2026 12:56:17 +0000
Subject: [PATCH] Bug 38414: (QA follow-up) Adjust templates

Now that we can explicitly list reports with any one of the permissions we need
to adjust some displays to ensure we can get to the list view.

Additionally I change 'Use saved' to 'View saved' since we may not be able to run.

I also fix the action buttons to show 'View' instead of 'Run' if user cannot execute.

I adjust reports home to check if the user can use report plugins before showing that link as well

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../intranet-tmpl/prog/en/includes/guided-reports-view.inc  | 4 ++--
 koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc   | 2 +-
 .../prog/en/modules/reports/guided_reports_start.tt         | 2 +-
 .../intranet-tmpl/prog/en/modules/reports/reports-home.tt   | 6 +++---
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/guided-reports-view.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/guided-reports-view.inc
index 59e416f7b8..fff76083c3 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/guided-reports-view.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/guided-reports-view.inc
@@ -1,8 +1,8 @@
 [% USE Koha %]
 <div id="guided-reports-view-menu" class="sidebar_menu">
-    <h5>Run reports</h5>
+    <h5>View reports</h5>
     <ul>
-        [% IF ( CAN_user_reports_execute_reports ) %]<li><a href="/cgi-bin/koha/reports/guided_reports.pl?op=list">Saved reports</a></li>[% END %]
+        [% IF ( CAN_user_reports_execute_reports || CAN_user_reports_create_reports || CAN_user_reports_delete_reports ) %]<li><a href="/cgi-bin/koha/reports/guided_reports.pl?op=list">Saved reports</a></li>[% END %]
     </ul>
     <h5>Reports dictionary</h5>
     <ul>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc
index 843d9a7453..984572e334 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc
@@ -7,7 +7,7 @@
             <li><a href="/cgi-bin/koha/reports/guided_reports.pl?op=add_form">Build new</a></li>
         [% END %]
         [% IF ( CAN_user_reports_execute_reports ) %]
-            <li><a href="/cgi-bin/koha/reports/guided_reports.pl?op=list">Use saved</a></li>
+            <li><a href="/cgi-bin/koha/reports/guided_reports.pl?op=list">View saved</a></li>
         [% END %]
         [% IF ( CAN_user_reports_create_reports ) %]
             <li><a href="/cgi-bin/koha/reports/guided_reports.pl?op=add_form_sql">Create from SQL</a></li>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
index af9074b34f..1a3bce8e92 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
@@ -212,7 +212,7 @@
                     [% END %]
 
                     [% IF ( CAN_user_reports_execute_reports ) %]
-                        <a href="/cgi-bin/koha/reports/guided_reports.pl?op=list" class="btn btn-primary">Use saved</a>
+                        <a href="/cgi-bin/koha/reports/guided_reports.pl?op=list" class="btn btn-primary">View saved</a>
                     [% END %]
 
                     [% IF ( CAN_user_reports_create_reports ) %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
index abd2eb9538..e1c503c7f3 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
@@ -31,7 +31,7 @@
             <h1>Reports</h1>
             <div class="row">
                 <div class="col-6">
-                    [% IF ( CAN_user_reports_execute_reports || CAN_user_reports_create_reports ) %]
+                    [% IF ( CAN_user_reports_execute_reports || CAN_user_reports_create_reports || CAN_user_reports_delete_reports ) %]
                         <fieldset class="brief">
                             <h2>Guided reports</h2>
                             [% IF ( CAN_user_reports_create_reports ) %]
@@ -43,7 +43,7 @@
                                 </p>
                             [% END %]
                             <p>
-                                <a href="/cgi-bin/koha/reports/guided_reports.pl?op=list"><i class="fa fa-list"></i> Use saved</a>
+                                <a href="/cgi-bin/koha/reports/guided_reports.pl?op=list"><i class="fa fa-list"></i> View saved</a>
                             </p>
                             <form action="/cgi-bin/koha/reports/guided_reports.pl" method="get">
                                 <input name="op" value="list" type="hidden" />
@@ -74,7 +74,7 @@
                         </ul>
                     </div>
 
-                    [% IF plugins_enabled %]
+                    [% IF ( plugins_enabled && CAN_user_plugins_report ) %]
                         <div class="rep_plugins">
                             <h2>Report plugins</h2>
                             <ul>