From fbdb96e293925b3f150c4ab33485286e9b5b4d95 Mon Sep 17 00:00:00 2001
From: Andrii Nugged <nugged@gmail.com>
Date: Mon, 29 Jul 2024 16:13:34 +0300
Subject: [PATCH] Bug 37865: Fix uninitialized value $op warns

[WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 144.
[WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 253.
These happen in cases when $op is undef and circulation.pl or returns.pl tries to directly compare it to a string.

To reproduce:
1. Go to "Check Out" and "Check In" circulation pages, or refresh already opened one.
2. Check your logs for "Use of uninitialized value $op" warning.
3. Apply patch.
4. Repeat step 1 and check that no new "Use of uninitialized value $op" error were logged.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Thomas Klausner <domm@plix.at>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 8e2b493d67814ce3411a3882446ac66239e4cbbb)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 circ/circulation.pl | 2 +-
 circ/returns.pl     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/circ/circulation.pl b/circ/circulation.pl
index f44005593d..a354c1257d 100755
--- a/circ/circulation.pl
+++ b/circ/circulation.pl
@@ -112,7 +112,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user (
     }
 );
 
-my $op                      = $query->param('op');
+my $op                      = $query->param('op') // '';
 my $override_high_holds     = $query->param('override_high_holds');
 my $override_high_holds_tmp = $query->param('override_high_holds_tmp');
 
diff --git a/circ/returns.pl b/circ/returns.pl
index 72e004a795..cb39bd4dfa 100755
--- a/circ/returns.pl
+++ b/circ/returns.pl
@@ -143,7 +143,7 @@ foreach ( $query->param ) {
     push( @inputloop, \%input );
 }
 
-my $op          = $query->param('op');
+my $op          = $query->param('op') // '';
 
 ############
 # Deal with the requests....