gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 18897: Skipping t/db_dependend/00-strict elastic search stuffs as needed 

Test Plan:
$ git fetch
$ git checkout -b bug_18897 origin/master
$ sudo apt-get remove libcatmandu-store-elasticsearch-perl
$ prove t/db_dependent/00-strict.t
-- nasty failure.
$ git bz apply 18897
-- interactive apply just the four patchs
$ prove t/db_dependent/00-strict.t
-- nicer skip message
run the koha qa test tools

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Mark Tompsett 2017-10-02 21:50:01 -04:00 committed by Fridolin Somers
parent 088e332760
commit faf651e514
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
t/db_dependent/00-strict.t
View File

@ -2,6 +2,7 @@
use strict;
use warnings;
use Module::Load::Conditional qw[can_load check_install requires];
use Test::More;
use Test::Strict;
use File::Spec;
@ -19,6 +20,24 @@ my @dirs = ( 'acqui', 'admin', 'authorities', 'basket',
'sms', 'suggestion', 'svc', 'tags', 'tools', 'virtualshelves' );
$Test::Strict::TEST_STRICT = 0;
$Test::Strict::TEST_SKIP = [ 'misc/kohalib.pl', 'sms/sms_listen_windows_start.pl', 'misc/plack/koha.psgi' ];
my $general_skips = [ 'misc/kohalib.pl', 'sms/sms_listen_windows_start.pl', 'misc/plack/koha.psgi' ];
my $elastic_search_files = [ 'misc/search_tools/rebuild_elastic_search.pl' ];
my @skips;
push @skips,@$general_skips;
if ( ! can_load(
modules => { 'Koha::SearchEngine::Elasticsearch::Indexer' => undef, } )
) {
my $missing_module;
if ( $Module::Load::Conditional::ERROR =~ /Can\'t locate (.*?) / ) {
$missing_module = $1;
}
my $es_dep_msg = "Required module $missing_module is not installed";
diag $es_dep_msg;
my $skip_what_msg = "Skipping: " . join ',', @$elastic_search_files;
diag $skip_what_msg;
push @skips, @$elastic_search_files;
}
push @$Test::Strict::TEST_SKIP, @skips;
all_perl_files_ok(@dirs);