gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 42490: Update unit tests 

Prove t/db_dependent/HoldsQueue.t

Sponsored-by: The Main Library Alliance <https://www.mainlib.org/>
Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
This commit is contained in:
Andrew Fuerste Henry 2026-05-01 17:35:06 +00:00 committed by Pedro Amorim
parent 662de2a955
commit fa3aacffd8
No known key found for this signature in database
GPG Key ID: 06B75BA7F3894D55
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
t/db_dependent/HoldsQueue.t
View File

@ -1102,10 +1102,11 @@ subtest "Test Local Holds Priority - Bib level" => sub {
};
subtest "Test Local Holds Priority - Item level" => sub {
plan tests => 2;
plan tests => 4;
Koha::Biblios->delete();
t::lib::Mocks::mock_preference( 'LocalHoldsPriority', 'GiveLibrary' );
t::lib::Mocks::mock_preference( 'LocalHoldsPriorityScope', 'checkin_and_queue' );
t::lib::Mocks::mock_preference( 'LocalHoldsPriorityPatronControl', 'PickupLibrary' );
t::lib::Mocks::mock_preference( 'LocalHoldsPriorityItemControl', 'homebranch' );
my $branch = $builder->build_object( { class => 'Koha::Libraries' } );
@ -1171,6 +1172,21 @@ subtest "Test Local Holds Priority - Item level" => sub {
$local_patron->borrowernumber,
"We should pick the local hold over the next available"
);
t::lib::Mocks::mock_preference( 'LocalHoldsPriorityScope', 'checkin_only' );
C4::HoldsQueue::CreateQueue();
my $queue_rs2 = $schema->resultset('TmpHoldsqueue');
my $q2 = $queue_rs2->next;
is(
$queue_rs2->count(), 1,
"Hold queue contains one hold"
);
is(
$q2->borrowernumber->borrowernumber,
$other_patron->borrowernumber,
"We should not pick the local hold over the next available"
);
};
subtest "Test Local Holds Priority - Item level hold over Record level hold (Bug 23934)" => sub {
@ -1180,6 +1196,7 @@ subtest "Test Local Holds Priority - Item level hold over Record level hold (Bug
t::lib::Mocks::mock_preference( 'LocalHoldsPriority', 'GiveLibrary' );
t::lib::Mocks::mock_preference( 'LocalHoldsPriorityPatronControl', 'PickupLibrary' );
t::lib::Mocks::mock_preference( 'LocalHoldsPriorityItemControl', 'homebranch' );
t::lib::Mocks::mock_preference( 'LocalHoldsPriorityScope', 'checkin_and_queue' );
my $branch = $builder->build_object( { class => 'Koha::Libraries' } );
my $branch2 = $builder->build_object( { class => 'Koha::Libraries' } );
my $category = $builder->build_object(