gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 27894: Unit tests 

This patch adds tests for the changed behavior.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Tomas Cohen Arazi 2021-03-11 09:26:32 -03:00 committed by Jonathan Druart
parent f470bee2e5
commit f98c4cec8e
1 changed files with 35 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
t/db_dependent/api/v1/holds.t
View File

@ -687,13 +687,26 @@ subtest 'add() tests (maxreserves behaviour)' => sub {
subtest 'pickup_locations() tests' => sub {
plan tests => 9;
plan tests => 12;
$schema->storage->txn_begin;
my $library_1 = $builder->build_object({ class => 'Koha::Libraries', value => { marcorgcode => 'A' } });
my $library_2 = $builder->build_object({ class => 'Koha::Libraries', value => { marcorgcode => 'B' } });
my $library_3 = $builder->build_object({ class => 'Koha::Libraries', value => { marcorgcode => 'C' } });
t::lib::Mocks::mock_preference( 'AllowHoldPolicyOverride', 0 );
# Small trick to ease testing
Koha::Libraries->search->update({ pickup_location => 0 });
my $library_1 = $builder->build_object({ class => 'Koha::Libraries', value => { marcorgcode => 'A', pickup_location => 1 } });
my $library_2 = $builder->build_object({ class => 'Koha::Libraries', value => { marcorgcode => 'B', pickup_location => 1 } });
my $library_3 = $builder->build_object({ class => 'Koha::Libraries', value => { marcorgcode => 'C', pickup_location => 1 } });
my $library_1_api = $library_1->to_api();
my $library_2_api = $library_2->to_api();
my $library_3_api = $library_3->to_api();
$library_1_api->{needs_override} = Mojo::JSON->false;
$library_2_api->{needs_override} = Mojo::JSON->false;
$library_3_api->{needs_override} = Mojo::JSON->false;
my $patron = $builder->build_object(
{
@ -790,19 +803,34 @@ subtest 'pickup_locations() tests' => sub {
$t->get_ok( "//$userid:$password@/api/v1/holds/"
. $hold_1->id
. "/pickup_locations" )
->json_is( [ $library_2->to_api, $library_3->to_api ] );
->json_is( [ $library_2_api, $library_3_api ] );
$t->get_ok( "//$userid:$password@/api/v1/holds/"
. $hold_2->id
. "/pickup_locations" )
->json_is( [ $library_1->to_api, $library_2->to_api ] );
->json_is( [ $library_1_api, $library_2_api ] );
# filtering works!
$t->get_ok( "//$userid:$password@/api/v1/holds/"
. $hold_2->id
. '/pickup_locations?q={"marc_org_code": { "-like": "A%" }}' )
->json_is( [ $library_1->to_api ] );
->json_is( [ $library_1_api ] );
t::lib::Mocks::mock_preference( 'AllowHoldPolicyOverride', 1 );
my $library_4 = $builder->build_object({ class => 'Koha::Libraries', value => { pickup_location => 0, marcorgcode => 'X' } });
my $library_5 = $builder->build_object({ class => 'Koha::Libraries', value => { pickup_location => 1, marcorgcode => 'Y' } });
my $library_5_api = $library_5->to_api();
$library_5_api->{needs_override} = Mojo::JSON->true;
# bibli-level mock doesn't include library_1 as valid pickup location
$library_1_api->{needs_override} = Mojo::JSON->true;
$t->get_ok( "//$userid:$password@/api/v1/holds/"
. $hold_1->id
. "/pickup_locations?_order_by=marc_org_code" )
->json_is( [ $library_1_api, $library_2_api, $library_3_api, $library_5_api ] );
$schema->storage->txn_rollback;
};