gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 41067: Disable OPAC mandatory when not editable 

If a patron attribute is not editable at the OPAC it should not be
possible to make it mandatory.

Test plan:
Create a new patron attribute and confirm that checkboxes behaviour is
consistent.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit d4a17b1b56)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Jonathan Druart 2025-10-23 12:57:42 +02:00 committed by Paul Derscheid
parent 98ec1e1134
commit f899e5447e
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
1 changed files with 34 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
View File

@ -408,6 +408,40 @@
[% INCLUDE 'datatables.inc' %]
[% INCLUDE 'select2.inc' %]
<script>
const opac_display = document.getElementById("opac_display");
const opac_editable = document.getElementById("opac_editable");
const opac_mandatory = document.getElementById("opac_mandatory");
function setDisabled(el, disabled) {
const label = el.closest("label");
if (disabled) {
el.checked = false;
el.disabled = true;
if (label) label.setAttribute("aria-disabled", "true");
} else {
el.disabled = false;
if (label) label.removeAttribute("aria-disabled");
}
}
function updateCheckboxes() {
if (!opac_display.checked) {
setDisabled(opac_editable, true);
} else {
setDisabled(opac_editable, false);
}
if (opac_editable.checked) {
setDisabled(opac_mandatory, false);
} else {
setDisabled(opac_mandatory, true);
}
}
opac_display.addEventListener("change", updateCheckboxes);
opac_editable.addEventListener("change", updateCheckboxes);
updateCheckboxes();
$(document).ready(function () {
function toggle_search_default() {
if ($("#staff_searchable").is(":checked")) {
@ -426,18 +460,6 @@
$("#branches option:first").attr("selected", "selected");
}
$("#opac_display")
.change(function () {
if (this.checked) {
$("#opac_editable").removeAttr("disabled").parent().removeAttr("aria-disabled");
$("#opac_mandatory").removeAttr("disabled").parent().removeAttr("aria-disabled");
} else {
$("#opac_editable").attr("disabled", true).parent().attr("aria-disabled", "true");
$("#opac_mandatory").attr("disabled", true).parent().attr("aria-disabled", "true");
}
})
.change();
$("#is_date")
.change(function () {
if (this.checked) {