Bug 37047: (QA follow-up) Remove nesting of document ready function

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit e9f3a7959a)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Martin Renvoize 2024-06-19 13:39:06 +01:00 committed by Lucas Gass
parent 95b107e014
commit f889259269
1 changed files with 93 additions and 96 deletions

View File

@ -1,102 +1,99 @@
/* keep tidy */
// Bookings
var bookings_table;
$(document).ready(function () {
var bookings_table;
$(document).ready(function () {
// Load bookings table on tab selection
$("#bookings-tab").on("click", function () {
if (!bookings_table) {
var today = new Date();
var bookings_table_url = "/api/v1/bookings";
bookings_table = $("#bookings_table").kohaTable(
{
ajax: {
url: bookings_table_url,
},
embed: ["biblio", "item", "patron"],
columns: [
{
data: "booking_id",
title: _("Booking ID"),
},
{
data: "biblio.title",
title: _("Title"),
searchable: true,
orderable: true,
render: function (data, type, row, meta) {
return $biblio_to_html(row.biblio, {
link: "bookings",
});
},
},
{
data: "item.external_id",
title: _("Item"),
searchable: true,
orderable: true,
defaultContent: _("Any item"),
render: function (data, type, row, meta) {
if (row.item) {
return (
row.item.external_id +
" (" +
row.booking_id +
")"
);
} else {
return null;
}
},
},
{
data: "start_date",
title: _("Start date"),
searchable: true,
orderable: true,
render: function (data, type, row, meta) {
return $date(row.start_date);
},
},
{
data: "end_date",
title: _("End date"),
searchable: true,
orderable: true,
render: function (data, type, row, meta) {
return $date(row.end_date);
},
},
{
data: "",
title: _("Actions"),
class: "actions",
searchable: false,
orderable: false,
render: function (data, type, row, meta) {
let result = "";
if (CAN_user_circulate_manage_bookings) {
result +=
'<button type="button" class="btn btn-default btn-xs cancel-action" data-toggle="modal" data-target="#cancelBookingModal" data-booking="' +
row.booking_id +
'"><i class="fa fa-trash" aria-hidden="true"></i> ' +
_("Cancel") +
"</button>";
}
return result;
},
},
],
// Load bookings table on tab selection
$("#bookings-tab").on("click", function () {
if (!bookings_table) {
var today = new Date();
var bookings_table_url = "/api/v1/bookings";
bookings_table = $("#bookings_table").kohaTable(
{
ajax: {
url: bookings_table_url,
},
table_settings_bookings_table,
0,
{
patron_id: patron_borrowernumber,
end_date: { ">=": today.toISOString() },
}
);
}
});
embed: ["biblio", "item", "patron"],
columns: [
{
data: "booking_id",
title: _("Booking ID"),
},
{
data: "biblio.title",
title: _("Title"),
searchable: true,
orderable: true,
render: function (data, type, row, meta) {
return $biblio_to_html(row.biblio, {
link: "bookings",
});
},
},
{
data: "item.external_id",
title: _("Item"),
searchable: true,
orderable: true,
defaultContent: _("Any item"),
render: function (data, type, row, meta) {
if (row.item) {
return (
row.item.external_id +
" (" +
row.booking_id +
")"
);
} else {
return null;
}
},
},
{
data: "start_date",
title: _("Start date"),
searchable: true,
orderable: true,
render: function (data, type, row, meta) {
return $date(row.start_date);
},
},
{
data: "end_date",
title: _("End date"),
searchable: true,
orderable: true,
render: function (data, type, row, meta) {
return $date(row.end_date);
},
},
{
data: "",
title: _("Actions"),
class: "actions",
searchable: false,
orderable: false,
render: function (data, type, row, meta) {
let result = "";
if (CAN_user_circulate_manage_bookings) {
result +=
'<button type="button" class="btn btn-default btn-xs cancel-action" data-toggle="modal" data-target="#cancelBookingModal" data-booking="' +
row.booking_id +
'"><i class="fa fa-trash" aria-hidden="true"></i> ' +
_("Cancel") +
"</button>";
}
return result;
},
},
],
},
table_settings_bookings_table,
0,
{
patron_id: patron_borrowernumber,
end_date: { ">=": today.toISOString() },
}
);
}
});
});