gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 23964: (follow-up) Add comments and improve readability 

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Nick Clemens 2019-11-06 14:59:03 +00:00 committed by Martin Renvoize
parent e083287048
commit f847cfdd7e
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
C4/Reserves.pm
View File

@ -174,7 +174,23 @@ sub AddReserve {
# of the document, we force the value $priority and $found .
if ( $checkitem and not C4::Context->preference('ReservesNeedReturns') ) {
my $item = Koha::Items->find( $checkitem ); # FIXME Prevent bad calls
if ( !$item->onloan && $item->holdingbranch eq $branch && ( $item->damaged && C4::Context->preference('AllowHoldsOnDamagedItems') || !$item->damaged ) && !$item->get_transfer && !$item->holds->count ) {
if (
# If item is already checked out, it cannot be set waiting
!$item->onloan
# The item can't be waiting if it needs a transfer
&& $item->holdingbranch eq $branch
# Similarly, if in transit it can't be waiting
&& !$item->get_transfer
# If we can't hold damaged items, and it is damaged, it can't be waiting
&& ( $item->damaged && C4::Context->preference('AllowHoldsOnDamagedItems') || !$item->damaged )
# Lastly, if this already has holds, we shouldn't make it waiting for the new hold
&& !$item->holds->count )
{
$priority = 0;
$found = 'W';
}