Bug 35466: (follow-up) Go to next if error, add to indexing call if not

Before the previous patch we were indexing with every AddAuthority/ModAuthority call and I assumed
we were also indexing during the commity, however, it appears we were not. This patch ensures we push
the record and ids into the arrays for indexing during commit.

Additionally I add a skip to next record on error, to match biblio behaviour.
I also correct a log referring to biblios during authority importing

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Thomas Klausner <domm@plix.at>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Nick Clemens 2024-08-23 13:14:58 +00:00 committed by Katrin Fischer
parent e01fb16455
commit f522fbff32
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
1 changed files with 5 additions and 1 deletions

View File

@ -480,6 +480,7 @@ RECORD: foreach my $record ( @{$marc_records} ) {
if ($@) {
warn "ERROR: Update authority $matched_record_id failed: $@\n";
printlog( { id => $matched_record_id, op => "update", status => "ERROR" } ) if ($logfile);
next RECORD;
} else {
printlog( { id => $authid, op => "update", status => "ok" } ) if ($logfile);
}
@ -500,6 +501,7 @@ RECORD: foreach my $record ( @{$marc_records} ) {
if ($@) {
warn "ERROR: Insert authority $originalid failed: $@\n";
printlog( { id => $originalid, op => "insert", status => "ERROR" } ) if ($logfile);
next RECORD;
} else {
printlog( { id => $authid, op => "insert", status => "ok" } ) if ($logfile);
}
@ -508,7 +510,7 @@ RECORD: foreach my $record ( @{$marc_records} ) {
printlog(
{
id => $originalid, op => "insert",
status => "warning : biblio not in database and option -insert not enabled, skipping..."
status => "warning : authority not in database and option -insert not enabled, skipping..."
}
) if ($logfile);
}
@ -520,6 +522,8 @@ RECORD: foreach my $record ( @{$marc_records} ) {
1 #@FIXME: Really always updated?
);
}
push @search_engine_record_ids, $authid;
push @search_engine_records, $record;
} else {
my ( $biblioitemnumber, $itemnumbers_ref, $errors_ref, $record_id );