gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 42254: (QA follow-up) Remove unused var, fixing a FIXME 

Test plan:
Read the patch. Look for the var in the script.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Marcel de Rooy 2026-04-17 09:18:54 +02:00 committed by Lucas Gass
parent 517edc11a8
commit f4e21f4199
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tags/review.pl
View File

@ -46,7 +46,7 @@ sub ajax_auth_cgi { # returns CGI object
my ($auth_status) = check_cookie_auth( $sessid, $needed_flags ); my ($auth_status) = check_cookie_auth( $sessid, $needed_flags );
if ( $auth_status ne "ok" ) { if ( $auth_status ne "ok" ) {
#FIMXE: This should return a HTTP error and not a script #FIXME: This should return a HTTP error and not a script
output_with_http_headers $input, undef, output_with_http_headers $input, undef,
"window.alert('Your CGI session cookie ($sessid) is not current. " "window.alert('Your CGI session cookie ($sessid) is not current. "
. "Please refresh the page and try again.');\n", 'js'; . "Please refresh the page and try again.');\n", 'js';
@ -58,9 +58,8 @@ sub ajax_auth_cgi { # returns CGI object
if ( is_ajax() ) { if ( is_ajax() ) {
my $input = &ajax_auth_cgi($needed_flags); my $input = &ajax_auth_cgi($needed_flags);
my $operator = C4::Context->userenv->{'number'}; # must occur AFTER auth my $operator = C4::Context->userenv->{'number'}; # must occur AFTER auth
my $js_reply; my $op = $input->param('op') || q{};
my $op = $input->param('op') || q{}; my $tag = $input->param('tag');
my $tag = $input->param('tag');
my $status; my $status;
if ( $op eq 'test' ) { if ( $op eq 'test' ) {
my $check = is_approved($tag); my $check = is_approved($tag);