Bug 17387: add restore records permission as child of cataloguing perms

Signed-off-by: Michaela <michaela.sieber@kit.edu>
Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

C4/Auth.pm

@@ -2329,6 +2329,7 @@ sub get_cataloguing_page_permissions {
         marc_modification_templates
         records_batchdel
         records_batchmod
+        records_restore
         stage_marc_import
         upload_cover_images
     );

api/v1/swagger/paths/deleted_biblios.yaml

@@ -171,4 +171,4 @@
           $ref: "../swagger.yaml#/definitions/error"
     x-koha-authorization:
       permissions:
-        editcatalogue: edit_catalogue
+        tools: records_restore

api/v1/swagger/paths/deleted_items.yaml

@@ -164,4 +164,4 @@
           $ref: "../swagger.yaml#/definitions/error"
     x-koha-authorization:
       permissions:
-        editcatalogue: edit_catalogue
+        tools: records_restore

installer/data/mysql/atomicupdate/bug_17387-item_biblio-undelete.pl

@@ -0,0 +1,21 @@
+use Modern::Perl;
+use Koha::Installer::Output qw(say_warning say_success say_info);
+
+return {
+    bug_number  => "17387",
+    description => "Add records_restore permission",
+    up          => sub {
+        my ($args) = @_;
+        my ( $dbh, $out ) = @$args{qw(dbh out)};
+
+        $dbh->do(
+            q{
+            INSERT IGNORE INTO permissions (module_bit, code, description)
+            VALUES (13, 'records_restore', 'Restore deleted records')
+        }
+        );
+
+        say_success( $out, "Added new permission 'tools:records_restore'" );
+
+    },
+};

installer/data/mysql/mandatory/userpermissions.sql

@@ -133,6 +133,7 @@ INSERT INTO permissions (module_bit, code, description) VALUES
    (13, 'records_batchmod', 'Perform batch modification of records (biblios or authorities)'),
    (13, 'marc_modification_templates', 'Manage marc modification templates'),
    (13, 'records_batchdel', 'Perform batch deletion of records (bibliographic or authority)'),
+   (13, 'records_restore', 'Restore deleted records'),
    (13, 'access_files', 'Access to the files stored on the server'),
    (13, 'upload_general_files', 'Upload any file'),
    (13, 'upload_manage', 'Manage uploaded files'),

koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc

@@ -463,6 +463,9 @@
     [%- CASE 'records_batchmod' -%]
         <span class="sub_permission records_batchmod_subpermission"> Perform batch modification of records (biblios or authorities) </span>
         <span class="permissioncode">([% name | html %])</span>
+    [%- CASE 'records_restore' -%]
+        <span class="sub_permission records_restore_subpermission"> Restore deleted records </span>
+        <span class="permissioncode">([% name | html %])</span>
     [%- CASE 'rotating_collections' -%]
         <span class="sub_permission rotating_collections_subpermission"> Manage rotating collections </span>
         <span class="permissioncode">([% name | html %])</span>

tools/restore-records.pl

@@ -29,7 +29,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
         template_name => "tools/restore-records.tt",
         query         => $input,
         type          => "intranet",
-        flagsrequired => { editcatalogue => 'edit_catalogue' },
+        flagsrequired => { tools => 'records_restore' },
     }
 );