Bug 16448: Fix perlcritic errors introduced by 12478
Bug 12478 introduced two perlcritic errors. This patch fixes them. To test: - On master, run: $ prove t/00-testcritic.t => FAIL: catalogue/search.pl and Koha/Authority.pm fail the critic tests. - Apply the patch - Run: $ prove t/00-testcritic.t => SUCCESS: All happy - Sign off :-D Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All test successful. Needs $ export TEST_QA=1 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>
This commit is contained in:
parent
44e0cb2895
commit
f4936b5763
|
|
@ -64,7 +64,7 @@ sub get_all_authorities_iterator {
|
|||
{ columns => [qw/ authid authtypecode marcxml /] } );
|
||||
my $next_func = sub {
|
||||
my $row = $rs->next();
|
||||
return undef if !$row;
|
||||
return if !$row;
|
||||
my $authid = $row->authid;
|
||||
my $authtypecode = $row->authtypecode;
|
||||
my $marcxml = $row->marcxml;
|
||||
|
|
|
|||
|
|
@ -472,8 +472,6 @@ my $builder = Koha::SearchEngine::QueryBuilder->new(
|
|||
my $searcher = Koha::SearchEngine::Search->new(
|
||||
{ index => $Koha::SearchEngine::BIBLIOS_INDEX } );
|
||||
|
||||
my @results;
|
||||
|
||||
## I. BUILD THE QUERY
|
||||
(
|
||||
$error, $query, $simple_query, $query_cgi,
|
||||
|
|
|
|||
Loading…
Reference in New Issue