gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 14098: Remove unedeed subroutines 

Just some cleaning before to continue, _copy_field and _copy_subfield did not
do anything useful.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Jonathan Druart 2015-05-27 13:34:09 +02:00 committed by Tomas Cohen Arazi
parent 8c132e956e
commit f37d9d005c
1 changed files with 48 additions and 119 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

167
Koha/SimpleMARC.pm
View File

@ -85,68 +85,32 @@ sub copy_field {
if ( ! ( $record && $fromFieldName && $toFieldName ) ) { return; }
if ( not $fromSubfieldName or $fromSubfieldName eq ''
or not $toSubfieldName or $toSubfieldName eq ''
) {
_copy_field({
record => $record,
from_field => $fromFieldName,
to_field => $toFieldName,
regex => $regex,
field_numbers => $field_numbers,
});
if ( not $fromSubfieldName
or $fromSubfieldName eq ''
or not $toSubfieldName
or $toSubfieldName eq '' ) {
_copy_move_field(
{ record => $record,
from_field => $fromFieldName,
to_field => $toFieldName,
regex => $regex,
field_numbers => $field_numbers,
action => 'copy',
}
);
} else {
_copy_subfield({
record => $record,
from_field => $fromFieldName,
from_subfield => $fromSubfieldName,
to_field => $toFieldName,
to_subfield => $toSubfieldName,
regex => $regex,
field_numbers => $field_numbers,
});
_copy_move_subfield(
{ record => $record,
from_field => $fromFieldName,
from_subfield => $fromSubfieldName,
to_field => $toFieldName,
to_subfield => $toSubfieldName,
regex => $regex,
field_numbers => $field_numbers,
action => 'copy',
}
);
}
}
sub _copy_field {
my ( $params ) = @_;
my $record = $params->{record};
my $fromFieldName = $params->{from_field};
my $toFieldName = $params->{to_field};
my $regex = $params->{regex};
my $field_numbers = $params->{field_numbers} // [];
_copy_move_field({
record => $record,
from_field => $fromFieldName,
to_field => $toFieldName,
regex => $regex,
field_numbers => $field_numbers,
action => 'copy',
});
}
sub _copy_subfield {
my ( $params ) = @_;
my $record = $params->{record};
my $fromFieldName = $params->{from_field};
my $fromSubfieldName = $params->{from_subfield};
my $toFieldName = $params->{to_field};
my $toSubfieldName = $params->{to_subfield};
my $regex = $params->{regex};
my $field_numbers = $params->{field_numbers} // [];
_copy_move_subfield({
record => $record,
from_field => $fromFieldName,
from_subfield => $fromSubfieldName,
to_field => $toFieldName,
to_subfield => $toSubfieldName,
regex => $regex,
field_numbers => $field_numbers,
action => 'copy',
});
}
sub update_field {
@ -416,69 +380,34 @@ sub move_field {
my $regex = $params->{regex};
my $field_numbers = $params->{field_numbers} // [];
if ( not $fromSubfieldName or $fromSubfieldName eq ''
or not $toSubfieldName or $toSubfieldName eq ''
) {
_move_field({
record => $record,
from_field => $fromFieldName,
to_field => $toFieldName,
regex => $regex,
field_numbers => $field_numbers,
});
if ( not $fromSubfieldName
or $fromSubfieldName eq ''
or not $toSubfieldName
or $toSubfieldName eq '' ) {
_copy_move_field(
{ record => $record,
from_field => $fromFieldName,
to_field => $toFieldName,
regex => $regex,
field_numbers => $field_numbers,
action => 'move',
}
);
} else {
_move_subfield({
record => $record,
from_field => $fromFieldName,
from_subfield => $fromSubfieldName,
to_field => $toFieldName,
to_subfield => $toSubfieldName,
regex => $regex,
field_numbers => $field_numbers,
});
_copy_move_subfield(
{ record => $record,
from_field => $fromFieldName,
from_subfield => $fromSubfieldName,
to_field => $toFieldName,
to_subfield => $toSubfieldName,
regex => $regex,
field_numbers => $field_numbers,
action => 'move',
}
);
}
}
sub _move_field {
my ( $params ) = @_;
my $record = $params->{record};
my $fromFieldName = $params->{from_field};
my $toFieldName = $params->{to_field};
my $regex = $params->{regex};
my $field_numbers = $params->{field_numbers} // [];
_copy_move_field({
record => $record,
from_field => $fromFieldName,
to_field => $toFieldName,
regex => $regex,
field_numbers => $field_numbers,
action => 'move',
});
}
sub _move_subfield {
my ( $params ) = @_;
my $record = $params->{record};
my $fromFieldName = $params->{from_field};
my $fromSubfieldName = $params->{from_subfield};
my $toFieldName = $params->{to_field};
my $toSubfieldName = $params->{to_subfield};
my $regex = $params->{regex};
my $field_numbers = $params->{field_numbers} // [];
_copy_move_subfield({
record => $record,
from_field => $fromFieldName,
from_subfield => $fromSubfieldName,
to_field => $toFieldName,
to_subfield => $toSubfieldName,
regex => $regex,
field_numbers => $field_numbers,
action => 'move',
});
}
=head2 _delete_field
_delete_field( $record, $fieldName[, $subfieldName [, $n ] ] );