gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 9274: Software error in bibtex export 

Exporting to Bibtex from OPAC returns a software error.
This is because call to C4::Biblio::GetMarcAuthors does
not return only authors but also authority link.
This patch replaces this call by a direct read of
MARC::Record, like for other Bibtex datas.
C4::Biblio::GetMarcAuthors is really destinated to a
direct use in a template.
Also, actually all author subfields are joined with
'and'. According to Bibtext format, authors should be
"firstname surname and ..." or "surname, firstname and
...". I have choosen second one because in non-UNIMARC
it corresponds to $a content.

For example UNIMARC :
700 $aDoe $bJohn
700 $aDoe $bJanne
Gives : Doe, John and Doe, Janne
For example MARC21 :
700 $aDoe, John
700 $aDoe, Janne
Gives : Doe, John and Doe, Janne

Test plan :
Without patch :
Exporting to Bibtex from OPAC returns a software error.
With patch :
Exporting to Bibtex from OPAC succeeds.
Authors are composed using : $a, $b and ... for UNIMARC, $a ... for other marc flavours.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Works as decribed. All record export that produces
error pre-patch, now export without error.
No koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixes error and output of additional authors.
Main entry in 100 is still missing.
All tests and  QA script pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
This commit is contained in:
Fridolyn SOMERS 2012-12-12 15:47:55 +01:00 committed by Jared Camins-Esakov
parent 4c7084d426
commit f355da2e86
1 changed files with 27 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
C4/Record.pm
View File

@ -647,18 +647,40 @@ C<$id> - an id for the BibTex record (might be the biblionumber)
sub marc2bibtex {
my ($record, $id) = @_;
my $tex;
my $marcflavour = C4::Context->preference("marcflavour");
# Authors
my $marcauthors = GetMarcAuthors($record,C4::Context->preference("marcflavour"));
my $author;
for my $authors ( map { map { @$_ } values %$_ } @$marcauthors ) {
$author .= " and " if ($author && $$authors{value});
$author .= $$authors{value} if ($$authors{value});
my @texauthors;
my ( $mintag, $maxtag, $fields_filter );
if ( $marcflavour eq "UNIMARC" ) {
$mintag = "700";
$maxtag = "712";
$fields_filter = '7..';
}
else {
$mintag = "700";
$maxtag = "720";
$fields_filter = '7..';
}
foreach my $field ( $record->field($fields_filter) ) {
next unless $field->tag() >= $mintag && $field->tag() <= $maxtag;
# author formatted surname, firstname
my $texauthor = '';
if ( $marcflavour eq "UNIMARC" ) {
$texauthor = join ', ',
( $field->subfield('a'), $field->subfield('b') );
}
else {
$texauthor = $field->subfield('a');
}
push @texauthors, $texauthor if $texauthor;
}
$author = join ' and ', @texauthors;
# Defining the conversion hash according to the marcflavour
my %bh;
if (C4::Context->preference("marcflavour") eq "UNIMARC") {
if ( $marcflavour eq "UNIMARC" ) {
# FIXME, TODO : handle repeatable fields
# TODO : handle more types of documents