gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 41042: default_save_state is enabled by default 

If 'default_save_state' is not in the yaml file then the feature is
enabled by default.

Caught by the following failure:
t/db_dependent/selenium/patrons_search.t ..
        #   Failed test 'Search works when category of patrons is limited to a library we are not signed in at'
        #   at t/db_dependent/selenium/patrons_search.t line 471.
        #          got: 'Showing 1 to 5 of 26 entries (filtered from 82 total entries)'
        #     expected: 'Showing 1 to 15 of 26 entries (filtered from 82 total entries)'
        # Looks like you failed 1 test of 1.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit eba0060286)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Jonathan Druart 2025-10-23 09:17:56 +02:00 committed by Paul Derscheid
parent fb29ac4205
commit f31a643ff0
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
C4/Utils/DataTables/TablesSettings.pm
View File

@ -121,7 +121,7 @@ sub get_table_settings {
$default_sort_order //= $table_settings->{default_sort_order};
my $default_save_state = $rs && $rs->default_save_state;
$default_save_state //= $table_settings->{default_save_state} // 0;
$default_save_state //= $table_settings->{default_save_state} // 1;
my $default_save_state_search = $rs && $rs->default_save_state_search;
$default_save_state_search //= $table_settings->{default_save_state_search} // 0;

6
t/db_dependent/TablesSettings.t
View File

@ -467,8 +467,10 @@ subtest 'test upgrade' => sub {
default_display_length => undef,
default_sort_order => undef,
# default_save_state is disabled by default but can be enabled.
default_save_state => 0,
# default_save_state is enabled by default but can be disabled
default_save_state => 1,
# default_save_state_search is disabled by default but can be enabled
default_save_state_search => 0,
}
);