From f3133f90954269b64552c08e36a08b6e46c7b2a2 Mon Sep 17 00:00:00 2001 From: Emmi Takkinen Date: Thu, 26 Sep 2024 08:22:13 +0300 Subject: [PATCH] Bug 37369: Fix filtering of search result table in item search At the moment, the filtering on item results page requires using the code in the following fields: - Collection - Home library - Current library - Shelving location - Itemtype - item status -fields (not for loan etc) So e.g. "Centerville" in Home library -field doesn't bring back results but code "CPL" does. This happens because "columns" option in search results table isn't working when its used in function columnFilter. However option "aoColumns" works. To test: 1. Navigate to item search and search items. => Note that all filters in search result table are free text fields. 2. Attempt to filter search results by home library with description of some library. => No results are displayed. 3. Now filter results with code of the library. => Results are now displayed. 4. Apply this patch and refresh page. 5. Search items again. => Note that now some of the filters are now using dropdown select fields. 6. Attempt to filter results by home library again. => Results are now displayed correctly. Sponsored-by: Koha-Suomi Oy Signed-off-by: Olivier Hubert Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize (cherry picked from commit a8401e533d0a3dd71560cc5be2c6451b170a5f54) Signed-off-by: Lucas Gass --- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt index 59b4c9225a..9d21f5b2c8 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt @@ -526,7 +526,7 @@ fixedHeader: false // There is a bug on this view })).columnFilter({ 'sPlaceHolder': 'head:after', - "columns": [ + "aoColumns": [ null, { 'type': 'text' }, { 'type': 'text' },