From ef8e3f67862503b1f3bc4be606ed4a68018dc1f1 Mon Sep 17 00:00:00 2001
From: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Date: Thu, 21 Aug 2025 10:54:28 +0000
Subject: [PATCH] Bug 40395: (QA follow-up): Remove unused form

This form is no longer used. We're now using a single cancellation hold modal and them form resides there, not here on this table
To test on the UI: Apply this patch and ensure cancelling holds works as before, from both pages (tested using borrowernumber 19:
<staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19
<staff_url>/cgi-bin/koha/reserve/request.pl?biblionumber=76&biblionumber=437&biblionumber=77

Fixed the failing test:
prove xt/find-missing-op-in-forms.t

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../prog/en/includes/patron-detail-tabs.inc   | 48 +++++++++----------
 1 file changed, 22 insertions(+), 26 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc
index b59888eca4..654a41a3de 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc
@@ -143,33 +143,29 @@
         [% IF ( CAN_user_circulate_circulate_remaining_permissions ) %]
             [% WRAPPER tab_panel tabname="holds" %]
                 [% IF ( holds_count ) %]
-                    <form action="/cgi-bin/koha/reserve/modrequest.pl" method="post">
-                        [% INCLUDE 'csrf-token.inc' %]
-                        <input type="hidden" name="from" value="circ" />
-                        <table id="holds-table" class="holds_table" style="width: 100% !Important;">
-                            <thead>
-                                <tr>
-                                    <th id="checkbox" data-colname="checkbox"><input type="checkbox" class="select_hold_all" /></th>
-                                    <th>Hold date</th>
-                                    <th class="anti-the">Title</th>
-                                    <th>Call number</th>
-                                    <th>Item type</th>
-                                    <th>Barcode</th>
-                                    <th>Pickup at</th>
-                                    <th>Expiration</th>
-                                    <th>Priority</th>
-                                    <th>Notes</th>
-                                    <th>Delete?</th>
-                                    <th>Suspend?</th>
-                                    <th>Status</th>
-                                </tr>
-                            </thead>
-                        </table>
+                    <table id="holds-table" class="holds_table" style="width: 100% !Important;">
+                        <thead>
+                            <tr>
+                                <th id="checkbox" data-colname="checkbox"><input type="checkbox" class="select_hold_all" /></th>
+                                <th>Hold date</th>
+                                <th class="anti-the">Title</th>
+                                <th>Call number</th>
+                                <th>Item type</th>
+                                <th>Barcode</th>
+                                <th>Pickup at</th>
+                                <th>Expiration</th>
+                                <th>Priority</th>
+                                <th>Notes</th>
+                                <th>Delete?</th>
+                                <th>Suspend?</th>
+                                <th>Status</th>
+                            </tr>
+                        </thead>
+                    </table>
 
-                        <fieldset class="action">
-                            <button class="btn btn-primary cancel_selected_holds" data-bulk="true"></button>
-                        </fieldset>
-                    </form>
+                    <fieldset class="action">
+                        <button class="btn btn-primary cancel_selected_holds" data-bulk="true"></button>
+                    </fieldset>
 
                     [% PROCESS 'cancel-hold-modal' form_action = '/cgi-bin/koha/reserve/modrequest.pl' from_param = patronpage %]
                     [% PROCESS 'suspend-hold-modal' %]