From ed337bfa0853e01c3efe918f00a5395c5dc4e7e8 Mon Sep 17 00:00:00 2001
From: nina martinez <nina.martinez@biblibre.com>
Date: Wed, 21 May 2025 17:02:49 +0200
Subject: [PATCH] Bug 39998: Add presentation role to the layout tables.

This patch improves the accessibility of the OPAC. It's a trivial patch
to help assistive technologies understand the different tables.

Test plan:

Enable the system preferences: OPACShelfBrowser, OPACPrivacy,
ShowComponentRecords.

1- On the Koha OPAC, Research a record.
2- Inspect the result page HTML and notice that there is a
   role='presentation' in the table tag.
3- Choose a record with a Component section and inspect the HTML, there
   should be a role='presentation' in the table tag.
4- Open the Browse shelf. Inspect the HTML and notice that there is a
   role='presentation' in the table tag of the browse shelf.
5- Log in to a patron account, go to the Your Summary page, and choose
   Privacy in the menu.
6- Inspect the HTML of the page and notice that there is a
   role='presentation' in the table tag of the 'Immediate deletion'.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit bc9dfb4b8e403ffd7cbb4ed8b612dbd3ba578099)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
(cherry picked from commit 428d7875269bc7c4d34a03876f7d949f781384e4)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc | 2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt    | 2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt   | 2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt   | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc
index d382a193c8..c5cf003852 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc
@@ -10,7 +10,7 @@
                 <a style="font-size: 75%;" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber | html %]" class="close_shelf" >Close shelf browser <span class="sr-only">(Hides shelf browser)</span></a>
             </h5>
 
-            <table class="table">
+            <table class="table" role="presentation ">
                 <tr>
                     <td class="nav-cell" rowspan="2">
                       [% IF shelfbrowser_prev_item %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
index ca3e204779..c1952f848f 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
@@ -623,7 +623,7 @@
                         [% IF ComponentParts && ComponentParts.size %]
                             [% WRAPPER tab_panel tabname="components" %]
                                 <div class="content_set">
-                                    <table>
+                                    <table role="presentation">
                                         [% FOR PART IN ComponentParts %]
                                             <tr>
                                                 <td>
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt
index bb1b0ee707..4e6a4593c2 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt
@@ -171,7 +171,7 @@
                             <input type="hidden" name="op" value="cud-delete_record" />
                             <input type="hidden" name="all" value="1" />
                         </form>
-                        <table class="table table-bordered table-condensed table-striped">
+                        <table class="table table-bordered table-condensed table-striped" role="presentation">
                             <tr>
                                 <td colspan=7>Immediately delete my checkout history. This action cannot be undone.</td>
                                 <td colspan=1>
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
index 4ada956bcf..558cf858c5 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
@@ -215,8 +215,8 @@
                                 </div> <!-- /#floating -->
 
                                 <!-- TABLE RESULTS START -->
-                                <table class="table table-striped">
-                                    <caption class="sr-only">Results</caption>
+                                <table class="table table-striped" role="presentation">
+                                    <span class="sr-only">Results</span>
 
                                     <!-- Actual Search Results -->
                                     [% FOREACH SEARCH_RESULT IN SEARCH_RESULTS %]