gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 31095: Remove GetDebarments from maxsuspensiondays.t 

This patch replaces GetDebarments in maxsuspensiondays.t with calls to
the restrictions accessor.

Test plan
1. Confirm t/db_dependent/Circulation/maxsuspensiondays.t passes prior
   to this patch
2. Confirm t/db_dependent/Circulation/maxsuspensiondays.t passes after
   this patch
3. Confirm no tests have been removed in this patch

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 07d3426ae8)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
This commit is contained in:
Martin Renvoize 2022-08-25 09:00:51 +01:00 committed by Matt Blenkinsop
parent 7c8b170ddb
commit e8cc616f0e
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
t/db_dependent/Circulation/maxsuspensiondays.t
View File

@ -9,7 +9,7 @@ use C4::Circulation qw( AddIssue AddReturn );
use C4::Biblio qw( AddBiblio );
use Koha::Database;
use Koha::DateUtils qw( dt_from_string output_pref );
use Koha::Patron::Debarments qw( GetDebarments DelDebarment );
use Koha::Patron::Debarments qw( DelDebarment );
use Koha::Patrons;
use t::lib::TestBuilder;
@ -48,7 +48,8 @@ my $borrowernumber = Koha::Patron->new({
categorycode => $patron_category->{categorycode},
branchcode => $branchcode,
})->store->borrowernumber;
my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
my $patron_object = Koha::Patrons->find( $borrowernumber );
my $borrower = $patron_object->unblessed;
my $record = MARC::Record->new();
$record->append_fields(
@ -76,13 +77,14 @@ my $daysafter40 = dt_from_string->add_duration(DateTime::Duration->new(days => 4
AddIssue( $borrower, $barcode, $daysago20 );
AddReturn( $barcode, $branchcode );
my $debarments = GetDebarments({borrowernumber => $borrower->{borrowernumber}});
my $debarments = $patron_object->restrictions;
my $THE_debarment = $debarments->next;
is(
$debarments->[0]->{expiration},
$THE_debarment->expiration,
output_pref({ dt => $daysafter40, dateformat => 'iso', dateonly => 1 }),
'calculate suspension with no maximum set'
);
DelDebarment( $debarments->[0]->{borrower_debarment_id} );
DelDebarment( $THE_debarment->borrower_debarment_id );
# Test with maxsuspensiondays = 10 days
Koha::CirculationRules->set_rules(
@ -99,13 +101,14 @@ Koha::CirculationRules->set_rules(
my $daysafter10 = dt_from_string->add_duration(DateTime::Duration->new(days => 10));
AddIssue( $borrower, $barcode, $daysago20 );
AddReturn( $barcode, $branchcode );
$debarments = GetDebarments({borrowernumber => $borrower->{borrowernumber}});
$debarments = $patron_object->restrictions;
$THE_debarment = $debarments->next;
is(
$debarments->[0]->{expiration},
$THE_debarment->expiration,
output_pref({ dt => $daysafter10, dateformat => 'iso', dateonly => 1 }),
'calculate suspension with a maximum set'
);
DelDebarment( $debarments->[0]->{borrower_debarment_id} );
DelDebarment( $THE_debarment->borrower_debarment_id );
subtest "suspension_chargeperiod" => sub {
Koha::CirculationRules->set_rules(