gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 19195: Preventing noisy warns when creating or editing a basket 

To test:
1) Open the koha intranet error log
2) Go to Acquisitions -> Find or create a vendor
3) Create a new basket, filling all fields
4) Notice warns in error log
5) Edit this basket
6) Notice warns in error log
7) Apply patch
8) Create another basket, confirm warns do not show
9) Edit this basket, confirm warns do not show

Sponsored-by: Catalyst IT

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit e98c178c08)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 43279f48e1)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This commit is contained in:
Aleisha Amohia 2017-08-29 05:02:29 +00:00 committed by Katrin Fischer
parent 876d955027
commit e371e274c6
1 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
acqui/basketheader.pl
View File

@ -69,11 +69,11 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
);
#parameters:
my $booksellerid = $input->param('booksellerid');
my $basketno = $input->param('basketno');
my $booksellerid = scalar $input->param('booksellerid');
my $basketno = scalar $input->param('basketno');
my $basket;
my $op = $input ->param('op');
my $is_an_edit= $input ->param('is_an_edit');
my $op = scalar $input->param('op');
my $is_an_edit = scalar $input->param('is_an_edit');
if ( $op eq 'add_form' ) {
my @contractloop;
@ -134,26 +134,26 @@ if ( $op eq 'add_form' ) {
if ( $is_an_edit ) {
ModBasketHeader(
$basketno,
$input->param('basketname'),
$input->param('basketnote'),
$input->param('basketbooksellernote'),
$input->param('basketcontractnumber') || undef,
$input->param('basketbooksellerid'),
$input->param('deliveryplace'),
$input->param('billingplace'),
$input->param('is_standing') ? 1 : undef,
scalar $input->param('basketname'),
scalar $input->param('basketnote'),
scalar $input->param('basketbooksellernote'),
scalar $input->param('basketcontractnumber') || undef,
scalar $input->param('basketbooksellerid'),
scalar $input->param('deliveryplace'),
scalar $input->param('billingplace'),
scalar $input->param('is_standing') ? 1 : undef,
);
} else { #New basket
$basketno = NewBasket(
$booksellerid,
$loggedinuser,
$input->param('basketname'),
$input->param('basketnote'),
$input->param('basketbooksellernote'),
$input->param('basketcontractnumber') || undef,
$input->param('deliveryplace'),
$input->param('billingplace'),
$input->param('is_standing') ? 1 : undef,
scalar $input->param('basketname'),
scalar $input->param('basketnote'),
scalar $input->param('basketbooksellernote'),
scalar $input->param('basketcontractnumber') || undef,
scalar $input->param('deliveryplace'),
scalar $input->param('billingplace'),
scalar $input->param('is_standing') ? 1 : undef,
);
}
print $input->redirect('basket.pl?basketno='.$basketno);