gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 40180: Add tests for insertSampleHold 

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit e3ee3a0541)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Jonathan Druart 2025-06-18 14:40:34 +02:00 committed by Paul Derscheid
parent f66133bcd5
commit e1fa9feb3f
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
2 changed files with 170 additions and 68 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

229
t/cypress/integration/t/insertData.ts
View File

@ -1,78 +1,173 @@
const { query } = require("./../../plugins/db.js");
const { getBasicAuthHeader } = require("./../../plugins/auth.js");
describe("insertSampleBiblio", () => {
it("insertSampleBiblio - should generate library and item type", () => {
cy.task("insertSampleBiblio", { item_count: 3 }).then(objects => {
expect(typeof objects.biblio.biblio_id).to.be.equal("number");
expect(typeof objects.biblio.title).to.be.equal("string");
expect(typeof objects.biblio.author).to.be.equal("string");
describe("insertData", () => {
describe("insertSampleBiblio", () => {
it("should generate library and item type", () => {
cy.task("insertSampleBiblio", { item_count: 3 }).then(objects => {
expect(typeof objects.biblio.biblio_id).to.be.equal("number");
expect(typeof objects.biblio.title).to.be.equal("string");
expect(typeof objects.biblio.author).to.be.equal("string");
const biblio_id = objects.biblio.biblio_id;
const biblio_id = objects.biblio.biblio_id;
cy.task("query", {
sql: "SELECT COUNT(*) as count FROM biblio WHERE biblionumber=?",
values: [biblio_id],
}).then(result => {
expect(result[0].count).to.be.equal(1);
cy.task("query", {
sql: "SELECT COUNT(*) as count FROM biblio WHERE biblionumber=?",
values: [biblio_id],
}).then(result => {
expect(result[0].count).to.be.equal(1);
});
cy.task("query", {
sql: "SELECT COUNT(*) as count FROM items WHERE biblionumber=?",
values: [biblio_id],
}).then(result => {
expect(result[0].count).to.be.equal(3);
});
cy.task("query", {
sql: "SELECT DISTINCT(itype) as count FROM items WHERE biblionumber=?",
values: [biblio_id],
}).then(result => {
expect(result.length).to.be.equal(1);
});
cy.task("query", {
sql: "SELECT COUNT(*) as count FROM branches WHERE branchcode=?",
values: [objects.libraries[0].library_id],
}).then(result => {
expect(result[0].count).to.be.equal(1);
});
cy.task("query", {
sql: "SELECT COUNT(*) as count FROM itemtypes WHERE itemtype=?",
values: [objects.item_type.item_type_id],
}).then(result => {
expect(result[0].count).to.be.equal(1);
});
cy.task("deleteSampleObjects", objects);
cy.task("query", {
sql: "SELECT COUNT(*) as count FROM biblio WHERE biblionumber=?",
values: [biblio_id],
}).then(result => {
expect(result[0].count).to.be.equal(0);
});
cy.task("query", {
sql: "SELECT COUNT(*) as count FROM items WHERE biblionumber=?",
values: [biblio_id],
}).then(result => {
expect(result[0].count).to.be.equal(0);
});
cy.task("query", {
sql: "SELECT COUNT(*) as count FROM branches WHERE branchcode=?",
values: [objects.libraries[0].library_id],
}).then(result => {
expect(result[0].count).to.be.equal(0);
});
cy.task("query", {
sql: "SELECT COUNT(*) as count FROM itemtypes WHERE itemtype=?",
values: [objects.item_type.item_type_id],
}).then(result => {
expect(result[0].count).to.be.equal(0);
});
});
});
cy.task("query", {
sql: "SELECT COUNT(*) as count FROM items WHERE biblionumber=?",
values: [biblio_id],
}).then(result => {
expect(result[0].count).to.be.equal(3);
});
it("insertSampleBiblio - options.different_libraries", () => {
cy.task("insertSampleBiblio", {
item_count: 3,
options: { different_libraries: true },
}).then(objects => {
expect(objects.libraries.length).to.be.equal(3);
let libraries = objects.libraries
.map(library => library.library_id)
.sort();
let itemsLibraries = objects.items
.map(item => item.home_library_id)
.sort();
expect(libraries).deep.to.equal(itemsLibraries);
cy.task("query", {
sql: "SELECT DISTINCT(itype) as count FROM items WHERE biblionumber=?",
values: [biblio_id],
}).then(result => {
expect(result.length).to.be.equal(1);
});
cy.task("query", {
sql: "SELECT COUNT(*) as count FROM branches WHERE branchcode=?",
values: [objects.libraries[0].library_id],
}).then(result => {
expect(result[0].count).to.be.equal(1);
});
cy.task("query", {
sql: "SELECT COUNT(*) as count FROM itemtypes WHERE itemtype=?",
values: [objects.item_type.item_type_id],
}).then(result => {
expect(result[0].count).to.be.equal(1);
});
cy.task("deleteSampleObjects", objects);
cy.task("query", {
sql: "SELECT COUNT(*) as count FROM biblio WHERE biblionumber=?",
values: [biblio_id],
}).then(result => {
expect(result[0].count).to.be.equal(0);
});
cy.task("query", {
sql: "SELECT COUNT(*) as count FROM items WHERE biblionumber=?",
values: [biblio_id],
}).then(result => {
expect(result[0].count).to.be.equal(0);
});
cy.task("query", {
sql: "SELECT COUNT(*) as count FROM branches WHERE branchcode=?",
values: [objects.libraries[0].library_id],
}).then(result => {
expect(result[0].count).to.be.equal(0);
});
cy.task("query", {
sql: "SELECT COUNT(*) as count FROM itemtypes WHERE itemtype=?",
values: [objects.item_type.item_type_id],
}).then(result => {
expect(result[0].count).to.be.equal(0);
cy.task("deleteSampleObjects", objects);
});
});
});
describe("insertSampleHold", () => {
it("insertSampleHold - item/biblio", () => {
cy.task("insertSampleBiblio", { item_count: 2 }).then(
objects_biblio => {
cy.task("insertSampleHold", {
item: objects_biblio.items[0],
}).then(objects_hold_1 => {
cy.task("insertSampleHold", {
biblio: objects_biblio.biblio,
library_id: objects_biblio.items[0].home_library_id,
}).then(objects_hold_2 => {
cy.task("apiGet", {
// No /holds/:hold_id (yet)
// No q={} (yet)
endpoint: `/api/v1/holds?hold_id=${objects_hold_1.hold.hold_id}`,
headers: {
"Content-Type": "application/json",
},
}).then(holds => {
expect(holds.length).to.be.equal(1);
expect(holds[0].biblio_id).to.be.equal(
objects_biblio.biblio.biblio_id
);
expect(holds[0].item_id).to.be.equal(
objects_biblio.items[0].item_id
);
});
cy.task("apiGet", {
// No /holds/:hold_id (yet)
// No q={} (yet)
endpoint: `/api/v1/holds?hold_id=${objects_hold_2.hold.hold_id}`,
headers: {
"Content-Type": "application/json",
},
}).then(holds => {
expect(holds.length).to.be.equal(1);
expect(holds[0].biblio_id).to.be.equal(
objects_biblio.biblio.biblio_id
);
expect(holds[0].item_id).to.be.equal(null);
});
cy.task("deleteSampleObjects", [
objects_biblio,
objects_hold_1,
objects_hold_2,
]);
});
});
}
);
});
// How to properly test for Error?
it.skip("insertSampleHold - missing library_id", () => {
cy.task("insertSampleBiblio", { item_count: 2 }).then(
objects_biblio => {
cy.task("insertSampleHold", {
biblio: objects_biblio.biblio,
}).then(
() => {
throw new Error("Task should have failed");
},
err => {
expect(err.message).to.include(
"Could not generate sample hold without library_id or item"
);
}
);
}
);
});
});
});

9
t/cypress/plugins/insertData.js
View File

@ -167,7 +167,14 @@ const insertSampleHold = async ({
baseUrl,
authHeader,
}) => {
library_id ||= item.home_library_id;
library_id ||= item?.home_library_id;
if (!library_id) {
throw new Error(
"Could not generate sample hold without library_id or item"
);
}
const generatedPatron = await buildSampleObject({
object: "patron",
values: { library_id, incorrect_address: null, patron_card_lost: null },