gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 39409: Duplicate modifybiblio ids in cat-toolbar 

The biblio details page Edit menu has three different elements which all
have id="modifybibilio", two of which also have another id. Neither of those
things is allowed.

Test plan:
1. Without the patch, load the details view for any biblio record and View
   source
2. Search for id="modifybiblio"
3. You will get three results, the second and third shown with id in red
4. Apply patch, reload the page, View source and search again
5. You will get one result, without any red

Sponsored-by: Chetco Community Public Library

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 8251e854d4)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Phil Ringnalda 2025-03-21 07:16:42 -07:00 committed by Fridolin Somers
parent 9e1b923873
commit e1bf45c2ea
No known key found for this signature in database
GPG Key ID: 9A8E73E2A8B96537
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
View File

@ -71,7 +71,7 @@
<input type="hidden" name="op" value="cud-show" />
<input type="hidden" name="biblionumber" value="[% biblionumber | html %]" />
<input type="hidden" name="src" value="CATALOGUING" />
<button id="batchedit" type="submit" class="dropdown-item" id="modifybiblio">Edit items in a batch</button>
<button id="batchedit" type="submit" class="dropdown-item">Edit items in a batch</button>
</form>
</li>
[% ELSE %]
@ -90,7 +90,7 @@
<input type="hidden" name="del" value="1" />
<input type="hidden" name="biblionumber" value="[% biblionumber | html %]" />
<input type="hidden" name="src" value="CATALOGUING" />
<button id="batchdelete" type="submit" class="dropdown-item" id="modifybiblio">Delete items in a batch</button>
<button id="batchdelete" type="submit" class="dropdown-item">Delete items in a batch</button>
</form>
</li>
[% ELSE %]