From e128051d09cd48062b712fe374e386606b6cf32b Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Fri, 11 Sep 2026 15:40:54 +0000 Subject: [PATCH] Bug 31391: (QA follow-up) Fix check for UseRecalls for messaging preferences in OPAC MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We are skipping the notice, if UseRecalls == "off". This now matches the check in staff too. A) Go to the KTD staff interface at http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=UseRecalls and set 'UseRecalls' to any non-'off' value, e.g. 'can be placed through the OPAC only'. B) Log into the OPAC at http://localhost:8080/cgi-bin/koha/opac-user.pl as any patron. C) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl D) Look for the recall-related notice row (item recalled / recall notices) — it's missing, even though recalls are enabled. E) Now flip 'UseRecalls' back to 'off' in step 1's page. F) Reload http://localhost:8080/cgi-bin/koha/opac-messaging.pl — the recall notice row now shows up, even though recalls are off. G) Steps 4 and 6 are the reverse of what should happen — confirms the condition is inverted. Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt index f9d0e608a0..7d0d10034b 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt @@ -77,7 +77,7 @@ [% NEXT IF !Koha.Preference('MembershipExpiryDaysNotice') && messaging_preference.Patron_Expiry %] [% NEXT IF messaging_preference.Patron_Expiry && enforce_expiry_notice %] [% NEXT IF messaging_preference.Auto_Renewals && Koha.Preference('AutoRenewalNotices') != 'preferences' %] - [% NEXT IF Koha.Preference('UseRecalls') != "off" && messaging_preference.message_name.match('^Recall_') %] + [% NEXT IF Koha.Preference('UseRecalls') == "off" && messaging_preference.message_name.match('^Recall_') %] [% IF ( messaging_preference.Item_Due ) %]