gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade 

This patch corrects the data attribute on "More" buttons which were
incorrectly updated during the Bootstrap 5 upgrade. "data-bs-target" is
corrected to "data-target."

Also fixed are instances of a misspelled class, "ligth" -> "light"

To test, apply the patch and go to Administration -> Identity providers.

- Click "New identity provider."
  - In the "Advanced configuration" section, test the "More" buttons
    underneath the textareas. Clicking them should expand the hidden
    help text and hide the button.
- Perform the same test when updating an identity provider.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit b138eb0e83)
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
This commit is contained in:
Owen Leonard 2025-01-25 15:36:25 +00:00 committed by Baptiste Wojtkowski
parent be7347f507
commit e0b01daef3
No known key found for this signature in database
GPG Key ID: 47A8A13E10BC0D40
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt
View File

@ -123,20 +123,20 @@
<label for="config" class="required json">Configuration: </label>
<textarea name="config" id="config" class="required" cols="75" rows="10"></textarea>
<span class="required">Required</span>
<div class="hint">Provider's main configuration. <button class="more btn btn-ligth" data-bs-target="config"><i class="fa fa-caret-down"></i> More</button></div>
<div class="hint">Provider's main configuration. <button class="more btn btn-light" data-target="config"><i class="fa fa-caret-down"></i> More</button></div>
<div class="hint more-config" style="display: none">
<div>This configuration differs for each protocol.</div>
<div>It is recommended to add the default configuration, and then replace with appropriate values</div>
</div>
<div class="hint">
<button class="btn btn-ligth defaults" data-default-target="config" id="default-config">Add default OAuth configuration</button>
<button class="btn btn-light defaults" data-default-target="config" id="default-config">Add default OAuth configuration</button>
</div>
</li>
<li>
<label for="mapping" class="required json">Mapping: </label>
<textarea name="mapping" id="mapping" class="required" cols="75" rows="10"></textarea>
<span class="required">Required</span>
<div class="hint">Map provider's result to Koha patron's fields. <button class="more btn btn-ligth" data-bs-target="mapping"><i class="fa fa-caret-down"></i> More</button></div>
<div class="hint">Map provider's result to Koha patron's fields. <button class="more btn btn-light" data-target="mapping"><i class="fa fa-caret-down"></i> More</button></div>
<div class="hint more-mapping" style="display: none">
<div>It is recommended to add the default mapping, and then modify to suit this provider's response</div>
<div>Keys represent Koha's fields, and values represent the keys in provider's result</div>
@ -145,7 +145,7 @@
<div>If you plan to use auto register feature, either <i>userid</i> or <i>cardnumber</i> must be present in this mapping</div>
</div>
<div class="hint">
<button class="btn btn-ligth defaults" data-default-target="mapping" id="default-mapping">Add default OAuth mapping</button>
<button class="btn btn-light defaults" data-default-target="mapping" id="default-mapping">Add default OAuth mapping</button>
</div>
</li>
<li>
@ -288,20 +288,20 @@
<label for="config" class="required json">Configuration: </label>
<textarea name="config" id="config" class="required" cols="75" rows="10">[%- identity_provider.config | html -%]</textarea>
<span class="required">Required</span>
<div class="hint">Provider's main configuration. <button class="more btn btn-ligth" data-bs-target="config"><i class="fa fa-caret-down"></i> More</button></div>
<div class="hint">Provider's main configuration. <button class="more btn btn-light" data-target="config"><i class="fa fa-caret-down"></i> More</button></div>
<div class="hint more-config" style="display: none">
<div>This configuration differs for each protocol.</div>
<div>It is recommended to add the default configuration, and then replace with appropriate values</div>
</div>
<div class="hint">
<button class="btn btn-ligth defaults" data-default-target="config" id="default-config">Add default [%- identity_provider.protocol | html -%] configuration</button>
<button class="btn btn-light defaults" data-default-target="config" id="default-config">Add default [%- identity_provider.protocol | html -%] configuration</button>
</div>
</li>
<li>
<label for="mapping" class="required json">Mapping: </label>
<textarea name="mapping" id="mapping" class="required" cols="75" rows="10">[%- identity_provider.mapping | html -%]</textarea>
<span class="required">Required</span>
<div class="hint">Map provider's result to Koha patron's fields. <button class="more btn btn-ligth" data-bs-target="mapping"><i class="fa fa-caret-down"></i> More</button></div>
<div class="hint">Map provider's result to Koha patron's fields. <button class="more btn btn-light" data-target="mapping"><i class="fa fa-caret-down"></i> More</button></div>
<div class="hint more-mapping" style="display: none">
<div>It is recommended to add the default mapping, and then modify to suit this provider's response</div>
<div>Keys represent Koha's fields, and values represent the keys in provider's result</div>
@ -310,7 +310,7 @@
<div>If you plan to use auto register feature, either <i>userid</i> or <i>cardnumber</i> must be present in this mapping</div>
</div>
<div class="hint">
<button class="btn btn-ligth defaults" data-default-target="mapping" id="default-mapping">Add default [%- identity_provider.protocol | html -%] mapping</button>
<button class="btn btn-light defaults" data-default-target="mapping" id="default-mapping">Add default [%- identity_provider.protocol | html -%] mapping</button>
</div>
</li>
<li>