Bug 40543: Remove pickup_library.branchname embed

This patch removes this wrongly added embed and adjusts the patron holds
history to use `pickup_location.name` instead.

To test:
1. Have a patron with some past holds from different branches
2. Browse their holds history
3. Search on the 'Library' column by name
=> SUCCESS: It works :-D
4. Apply the patch
5. Run:
   $ ktd --shell
  k$ yarn api:bundle
  k$ koha-plack --restart kohadev
6. Repeat 2-3
=> SUCCESS: Still works!
7. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 260a0af5db)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
(cherry picked from commit 9488baf31f)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

api/v1/swagger/paths/patrons_holds.yaml

@@ -34,7 +34,6 @@
             - deleted_biblio
             - item
             - pickup_library
-            - pickup_library.branchname
         collectionFormat: csv
     produces:
       - application/json

koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt

@@ -215,7 +215,7 @@
                 };
 
                 let table_url = '/api/v1/patrons/[% patron.borrowernumber | uri %]/holds';
-                let table_embeds = ['+strings', 'biblio', 'item', 'pickup_library', 'pickup_library.branchname'];
+                let table_embeds = ['+strings', 'biblio', 'item', 'pickup_library'];
                 if (old){
                     table_url += '?old=1';
                     table_embeds.push('deleted_biblio');
@@ -265,7 +265,7 @@
                             }
                         },
                         {
-                            data: "pickup_library_id:pickup_library.branchname",
+                            data: "pickup_library_id:pickup_library.name",
                             searchable: true,
                             orderable: true,
                             render: function (data, type, row, meta) {