gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 38343: (QA follow-up) Improve tests and tidy 

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Emily Lamancusa 2024-11-20 09:41:22 -05:00 committed by Katrin Fischer
parent ed48029c7f
commit d013a4aef0
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
2 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
acqui/parcels.pl
View File

@ -151,8 +151,8 @@ $template->param(
);
my $bookseller = Koha::Acquisition::Booksellers->find( $booksellerid );
my @parcels = GetInvoices(
supplierid => $booksellerid,
my @parcels = GetInvoices(
supplierid => $booksellerid,
invoicenumber => $code,
( $datefrom ? ( shipmentdatefrom => $datefrom ) : () ),
( $dateto ? ( shipmentdateto => $dateto ) : () ),

15
t/db_dependent/Acquisition/Invoices.t
View File

@ -8,7 +8,7 @@ use Koha::Acquisition::Booksellers;
use Koha::Acquisition::Orders;
use Koha::Database;
use Test::More tests => 27;
use Test::More tests => 29;
BEGIN {
use_ok('C4::Acquisition', qw( NewBasket GetBasket AddInvoice GetInvoice ModReceiveOrder GetInvoiceDetails GetInvoices ModInvoice CloseInvoice ReopenInvoice MergeInvoices DelInvoice ));
@ -107,7 +107,6 @@ my $invoiceid_closed = AddInvoice(
closedate => '2024-12-13',
);
my $invoice1 = GetInvoice( $invoiceid1 );
my $invoice2 = GetInvoice( $invoiceid2 );
@ -170,10 +169,14 @@ is($invoices[0]->{invoicenumber}, 'invoice1', 'GetInvoices() to search by ISBN w
@invoices = GetInvoices(isbneanissn => '123456789');
is($invoices[0]->{invoicenumber}, 'invoice1', 'GetInvoices() to search by partial ISBN works (bug 8854)');
@invoices = GetInvoices(booksellerid => $booksellerid, closedate => undef);
is(scalar @invoices, 2, );
is($invoices[0]->{invoicenumber}, 'invoice1', 'GetInvoices()');
is($invoices[1]->{invoicenumber}, 'invoice2', 'GetInvoices()');
@invoices = GetInvoices( booksellerid => $booksellerid, closedate => undef );
is( scalar @invoices, 2, 'GetInvoices() to search by only open invoices' );
is( $invoices[0]->{invoicenumber}, 'invoice1', 'GetInvoices() to search by only open invoices' );
is( $invoices[1]->{invoicenumber}, 'invoice2', 'GetInvoices() to search by only open invoices' );
@invoices = GetInvoices( booksellerid => $booksellerid, closedate => '2024-12-13' );
is( scalar @invoices, 1, 'GetInvoices() to filter by closedate' );
is( $invoices[0]->{invoicenumber}, 'invoice_close', 'GetInvoices() to filter by closedate' );
my $invoicesummary1 = GetInvoice($invoiceid1);
is($invoicesummary1->{'invoicenumber'}, 'invoice1', 'GetInvoice retrieves correct invoice');