gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 40347: Remove warnings from Koha/Hold.t 

Those diag statements are not really needed

    # Filling a hold when pref enabled should trigger a test
    # Filling a hold when pref disabled should not trigger a test
    # Updating a hold location when pref disabled should not trigger a test
    # Updating a hold location when pref enabled should trigger a test
    # Update with no change to pickup location should not trigger a test

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit b6c8cee965)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Jonathan Druart 2025-07-11 10:30:36 +02:00 committed by Paul Derscheid
parent b1ce0e9f57
commit cfe55afa92
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
t/db_dependent/Koha/Hold.t
View File

@ -367,7 +367,7 @@ subtest 'fill() tests' => sub {
t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 1 );
diag("Filling a hold when pref enabled should trigger a test");
# Filling a hold when pref enabled should trigger a test
$builder->build_object(
{
class => 'Koha::Holds',
@ -379,7 +379,7 @@ subtest 'fill() tests' => sub {
t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 0 );
diag("Filling a hold when pref disabled should not trigger a test");
# Filling a hold when pref disabled should not trigger a test
$builder->build_object(
{
class => 'Koha::Holds',
@ -411,16 +411,17 @@ subtest 'fill() tests' => sub {
)->store;
# Pref is off, no test triggered
diag("Updating a hold location when pref disabled should not trigger a test");
# Updating a hold location when pref disabled should not trigger a test
$hold->branchcode( $library_2->branchcode )->store;
t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 1 );
diag("Updating a hold location when pref enabled should trigger a test");
# Updating a hold location when pref enabled should trigger a test
# Pref is on, test triggered
$hold->branchcode( $library_1->branchcode )->store;
diag("Update with no change to pickup location should not trigger a test");
# Update with no change to pickup location should not trigger a test
$hold->branchcode( $library_1->branchcode )->store;
};