From ccc5ca534c65a2cef1d694756d0feef81594509c Mon Sep 17 00:00:00 2001 From: Emily Lamancusa Date: Mon, 23 Mar 2026 11:07:56 -0400 Subject: [PATCH] Bug 42147: Update tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To test: prove t/db_dependent/Reserves.t Signed-off-by: Emmanuel Bétemps Signed-off-by: Andrew Fuerste Henry Signed-off-by: Martin Renvoize --- t/db_dependent/Reserves.t | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t index 988717b26c..95332696bb 100755 --- a/t/db_dependent/Reserves.t +++ b/t/db_dependent/Reserves.t @@ -2058,7 +2058,7 @@ subtest 'CheckReserves() item type tests' => sub { }; subtest 'Bug 40866: AddReserve override JSON logging' => sub { - plan tests => 8; + plan tests => 9; $schema->storage->txn_begin; @@ -2104,7 +2104,10 @@ subtest 'Bug 40866: AddReserve override JSON logging' => sub { ); is( $logs->count, 1, 'One log entry created for normal hold' ); my $log = $logs->next; - is( $log->info, $hold_id, 'Normal hold logs hold ID only' ); + + my $log_data = eval { from_json( $log->info ) }; + ok( !$@, 'Log info is valid JSON' ); + ok( !defined( $log_data->{confirmations} ), 'Confirmations array is undefined' ); # Cancel the hold for next test my $hold = Koha::Holds->find($hold_id); @@ -2134,7 +2137,7 @@ subtest 'Bug 40866: AddReserve override JSON logging' => sub { is( $logs->count, 1, 'One log entry created for override hold' ); $log = $logs->next; - my $log_data = eval { from_json( $log->info ) }; + $log_data = eval { from_json( $log->info ) }; ok( !$@, 'Log info is valid JSON' ); ok( exists $log_data->{confirmations}, 'JSON contains confirmations array' ); is_deeply(