gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 27131: (QA follow-up) POD and comments 

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Marcel de Rooy 2021-02-18 07:47:11 +00:00 committed by Jonathan Druart
parent 731ec77b99
commit c3cf9a1ef9
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Koha/Holds.pm
View File

@ -92,6 +92,12 @@ sub forced_hold_level {
return;
}
=head3 get_items_that_can_fill
Developer will certainly submit an appropriate description.
=cut
sub get_items_that_can_fill {
my ( $self ) = @_;

3
t/db_dependent/Koha/Holds.t
View File

@ -414,6 +414,7 @@ subtest 'get_items_that_can_fill' => sub {
my $biblio = $builder->build_sample_biblio;
my $item_1 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } );
# waiting
my $item_2 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } );
my $item_3 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } )
; # onloan
@ -481,7 +482,7 @@ subtest 'get_items_that_can_fill' => sub {
my @items = $holds->get_items_that_can_fill;
is_deeply( [ map { $_->itemnumber } @items ],
[ $item_2->itemnumber, $item_5->itemnumber ], 'Only item 1 and 5 are available for filling the hold' );
[ $item_2->itemnumber, $item_5->itemnumber ], 'Only item 2 and 5 are available for filling the hold' );
};
$schema->storage->txn_rollback;