gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 41619: (Follow-up) Fix for t/Koha/CSV.t 

This patch fixes an omission that caused t/Koha/CSV.t to fail. To test, prove t/Koha/CSV.t and notice how it now passes.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Jake Deery 2026-02-27 11:08:32 +00:00 committed by Lucas Gass
parent 300f121b66
commit c3cf41c275
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Koha/CSV.pm
View File

@ -91,7 +91,7 @@ sub new {
my $self = $class->SUPER::new( my $self = $class->SUPER::new(
{ {
binary => 1, # Always 1 for UTF-8 binary => 1, # Always 1 for UTF-8
formula => undef, # Hard-coded to empty for security formula => 'empty', # Hard-coded to 'empty' for security
always_quote => $params->{always_quote} // 0, # Overridable always_quote => $params->{always_quote} // 0, # Overridable
eol => $params->{eol} // "\n", # Overridable eol => $params->{eol} // "\n", # Overridable
sep_char => $sep_char, # From Koha config or override sep_char => $sep_char, # From Koha config or override
@ -101,7 +101,7 @@ sub new {
$self->{_csv} = Text::CSV_XS->new( $self->{_csv} = Text::CSV_XS->new(
{ {
binary => $self->binary, binary => $self->binary,
formula => $self->formula // 'empty', formula => $self->formula // 'empty', # Hard-coded catch-all of 'empty' for security
always_quote => $self->always_quote, always_quote => $self->always_quote,
eol => $self->eol, eol => $self->eol,
sep_char => $self->sep_char, sep_char => $self->sep_char,