gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 37913: Remove more unreachable code in aqcontract.tt 

When you successfully delete an acquisitions contract, you are redirected to
the page with the vendor details, which shows contracts for that vendor, which
shows you that the contract you deleted was deleted.

The aqcontract.tt template has a block in [% IF ( delete_confirmed ) %] (which
is never set) that thinks it will show you a '<h1>Contract deleted</h1>' and
make you click an OK button. That block has never been shown, but the button
is in a form which POSTs without an 'op' param, which is now forbidden by the
CSRF code, and will be caught by a test once bug 37728 updates the test.

There's nothing visible to test, so the test plan just makes sure nothing
blows up and you can still delete a contract.

1. Nothing will change, so start with the patch applied
2. Acquistions - click the Search button to search for vendors
3. New -> Contract
4. Give it a name, a start date, and an end date, and Save
5. In the list of contracts for My Vendor, click the Delete button for
   the contract you created
6. In the confirmation page asking if you wanted to delete, click 'Yes,
   delete contract'
7. Note that you are at acqui/supplier.pl?booksellerid=1, the details page
   for the vendor, and your contract isn't listed at the bottom of the page,
   and especially that you weren't shown a page that just said "Contract
   deleted."

Sponsored-by: Chetco Community Public Library
Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 1264ece1f9)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Phil Ringnalda 2024-09-12 15:07:50 -07:00 committed by Lucas Gass
parent c2867900f5
commit c27d242adb
1 changed files with 1 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt
View File

@ -18,9 +18,7 @@
[% IF ( delete_confirm ) %]
[% tx("Confirm deletion of contract '{contractnumber}'", { contractnumber = contractnumber }) | html %]
[% END %]
[% IF ( delete_confirmed ) %]
[% t("Contract deleted") | html %]
[% END %] &rsaquo;
&rsaquo;
[% t("Contracts") | html %] &rsaquo;
[% t("Acquisitions") | html %] &rsaquo;
[% t("Koha") | html %]
@ -70,12 +68,6 @@
<span>Confirm deletion of contract [% contractnumber | html %]</span>
[% END %]
[% END %]
[% IF ( delete_confirmed ) %]
[% WRAPPER breadcrumb_item bc_active=1 %]
<span>Contract deleted</span>
[% END %]
[% END %]
[% END #/ WRAPPER breadcrumbs %]
[% END #/ WRAPPER sub-header.inc %]
@ -162,14 +154,6 @@
</form>
</div>
[% END %]
[% IF ( delete_confirmed ) %]
<h1>Contract deleted</h1>
<form action="[% script_name | html %]" method="post">
[% INCLUDE 'csrf-token.inc' %]
<input type="hidden" name="booksellerid" value="[% booksellerid | html %]" />
<input type="submit" class="btn btn-primary" value="OK" />
</form>
[% END %]
[% IF ( else ) %]
<h1>Contract(s) of [% booksellername | html %]</h1>
[% IF ( loop ) %]