From c18964a48fcb3032e424950eca2bbf8a549cf4c8 Mon Sep 17 00:00:00 2001
From: Lari Taskula <lari.taskula@hypernova.fi>
Date: Wed, 18 Sep 2024 10:21:47 +0000
Subject: [PATCH] Bug 28907: Add REST exceptions for public routes auth

To test:
1. perl -c Koha/REST/Plugin/Exceptions.pm
2. perl -c Koha/Exceptions/REST.pm

More tests coming in following patches.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 Koha/Exceptions/REST.pm        |  6 ++++++
 Koha/REST/Plugin/Exceptions.pm | 16 ++++++++++++++++
 2 files changed, 22 insertions(+)

diff --git a/Koha/Exceptions/REST.pm b/Koha/Exceptions/REST.pm
index bbcd0fed6b..f0150503c5 100644
--- a/Koha/Exceptions/REST.pm
+++ b/Koha/Exceptions/REST.pm
@@ -8,6 +8,12 @@ use Exception::Class (
     'Koha::Exceptions::REST' => {
         isa => 'Koha::Exception',
     },
+    'Koha::Exceptions::REST::Public::Authentication::Required' => {
+        description => "This public route requires authentication",
+    },
+    'Koha::Exceptions::REST::Public::Unauthorized' => {
+        description => "Unprivileged user cannot access another user's resources",
+    },
     'Koha::Exceptions::REST::Query::InvalidOperator' => {
         description => "Invalid operator found in query",
         fields      => ['operator']
diff --git a/Koha/REST/Plugin/Exceptions.pm b/Koha/REST/Plugin/Exceptions.pm
index ccf73e24be..d6a0e37f56 100644
--- a/Koha/REST/Plugin/Exceptions.pm
+++ b/Koha/REST/Plugin/Exceptions.pm
@@ -67,6 +67,22 @@ sub register {
                         error_code => 'invalid_query',
                     }
                 );
+            } elsif ( blessed $exception
+                && ref($exception) eq 'Koha::Exceptions::REST::Public::Authentication::Required' )
+            {
+                return $c->render(
+                    status => 401,
+                    json   => {
+                        error => $exception->error,
+                    }
+                );
+            } elsif ( blessed $exception && ref($exception) eq 'Koha::Exceptions::REST::Public::Unauthorized' ) {
+                return $c->render(
+                    status => 403,
+                    json   => {
+                        error => $exception->error,
+                    }
+                );
             }
 
             if ( blessed $exception ) {