Bug 39569: Fix branch name in alert when cancelling holds over x

To test:
1. On a bib with one item place a hold for pickup at library A and Library B
2. Check the item into library A
3. Set the first hold's expiration date to the past
4. On Holds awaiting pickup > Holds waiting past their expiration date
   In the actions column click the 'Cancel hold' button
5. Notice the alert says 'This item is on hold for pick-up at'
   with no library name
6. Apply patch and redo steps 1-4
7. Confirm the alert include's Library B's name
   This item is on hold for pick-up at Library B

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Brendan Lawlor 2025-04-04 18:41:54 +00:00 committed by Katrin Fischer
parent 1745aa69d9
commit c095e09ff9
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
1 changed files with 1 additions and 1 deletions

View File

@ -54,7 +54,7 @@
[% FOREACH cancel_result %]
[% IF ( messagetransfert ) %]
<div class="alert alert-info">
<h2>This item is on hold for pick-up at [% Branches.GetName( branchname ) | html %]</h2>
<h2>This item is on hold for pick-up at [% Branches.GetName( branchcode ) | html %]</h2>
<p><strong>[% nextreservtitle | html %]</strong> is on hold for <strong> [% nextreservsurname | html %], [% nextreservfirstname | html %]</strong>. Please retain this item and check it in to process the hold. </p>
<form name="cancelReservewithtransfert" action="waitingreserves.pl#[% tab | html %]" method="get">
<button type="submit" class="btn btn-default approve"><i class="fa fa-fw fa-check"></i> OK</button>