gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 41116: Standardize selectors in patron contact information in hold found modals 

This patch modifies both hold-found-modal and hold-found1. It adds a
class to the patron phone number. For patron email, it changes the
existing id to a class, expands the selector to include the bullet
point in hold-found-modal, and standardizes the name (changing from
"#boreamil' to ".patronemail").

To test:
1 - have a patron with both a phone number and an email address
2 - create a hold for your patron
3 - check an item in to fill your hold, triggering the hold-found-modal
4 - inspect the patron contact info, confirm there is no class on the
    phone number
5 - confirm there is an id on the patron email but it does not include
    the bullet point and is inconsistent with the names of other classes
    in the modal
6 - click Confirm Hold
7 - check your item in again, triggering the hold-found1 modal
8 - confirm there is no class on the patron phone number
9 - confirm there is an id on the patron email with an inconsistent
    name
10 - revert the waiting status of your hold
11 - apply patch, restart_all
12 - check your item in again, triggering hold-found-modal
13 - confirm the patron phone now has a class, .patronphone
14 - confirm the patron email now has a class, .patronemail, that the
     class includes the bullet point, and that the #boremail id has been
     removed
15 - click Confirm Hold
16 - check your item in again, triggering hold-found1 modal
17 - confirm the patron phone now has a class, .patronphone
18 - confirm the patron email now has a class, .patronemail, and that
     the #boremail id has been removed

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Andrew Fuerste Henry 2025-10-28 14:31:03 +00:00 committed by Lucas Gass
parent d95de3d3c3
commit bf451c7fe9
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
View File

@ -84,15 +84,15 @@
[% INCLUDE display_holdpatron_address %]
[% IF ( patron.phone ) %]
<li>[% patron.phone | html %]</li>
<li class="patronphone">[% patron.phone | html %]</li>
[% END %]
[% IF ( patron.email ) %]
<li>
<li class="patronemail">
[% IF ( transfertodo ) %]
[% patron.email | html %]
[% ELSE %]
<a id="boremail" href="mailto:[% patron.email | html %]">[% patron.email | html %]</a>
<a href="mailto:[% patron.email | html %]">[% patron.email | html %]</a>
[% END %]
</li>
[% END %]
@ -704,10 +704,10 @@
</li>
[% INCLUDE display_holdpatron_address %]
[% IF ( patron.phone ) %]
<li> [% patron.phone | html %]</li>
<li class="patronphone"> [% patron.phone | html %]</li>
[% END %]
[% IF ( patron.email ) %]
<li><a id="boremail" href="mailto:[% patron.email | html %]">[% patron.email | html %]</a></li>
<li class="patronemail"><a href="mailto:[% patron.email | html %]">[% patron.email | html %]</a></li>
[% END %]
[% IF ( patron.smsalertnumber ) %]
@ -919,15 +919,15 @@
[% INCLUDE display_holdpatron_address %]
[% IF ( patron.phone ) %]
<li>[% patron.phone | html %]</li>
<li class="patron-phone">[% patron.phone | html %]</li>
[% END %]
[% IF ( patron.email ) %]
<li>
<li class="patronemail">
[% IF ( transfertodo ) %]
[% patron.email | html %]
[% ELSE %]
<a id="boremail" href="mailto:[% patron.email | html %]">[% patron.email | html %]</a>
<a href="mailto:[% patron.email | html %]">[% patron.email | html %]</a>
[% END %]
</li>
[% END %]
@ -1037,7 +1037,7 @@
[% INCLUDE display_holdpatron_address patron=recall.patron %]
[% IF ( recall.patron.phone ) %]
<li>[% recall.patron.phone | html %]</li>
<l >[% recall.patron.phone | html %]</li>
[% END %]
[% IF ( recall.patron.email ) %]