gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

acceptorreject.pl cleanup 

Perltidy the ugly block (still ugly).
Use elsif where appropriate.
Added FIXME.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This commit is contained in:
Joe Atzberger 2009-04-07 17:37:54 -05:00 committed by Galen Charlton
parent 4a1333c544
commit be06bf0554
1 changed files with 28 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
suggestion/acceptorreject.pl
View File

@ -141,10 +141,10 @@ if ( $op eq "aorr_confirm" ) {
if (scalar(@deletelist)>0){
my $params = "&delete_field=".join ("&delete_field=",@deletelist);
print $input->redirect("/cgi-bin/koha/suggestion/acceptorreject.pl?op=delete_confirm$params");
exit;
}
}
if ( $op eq "delete_confirm" ) {
elsif ( $op eq "delete_confirm" ) {
my @delete_field = $input->param("delete_field");
foreach my $delete_field (@delete_field) {
&DelSuggestion( $loggedinuser, $delete_field,"intranet" );
@ -153,28 +153,36 @@ if ( $op eq "delete_confirm" ) {
}
my $reasonsloop = GetAuthorisedValues("SUGGEST");
my $pending_suggestions = &SearchSuggestion( "", "", "", "", 'ASKED', "",$branchcode );
map{$_->{'reasonsloop'}=$reasonsloop;$_->{'date'}=format_date($_->{'date'})} @$pending_suggestions;
my $accepted_suggestions = &GetSuggestionByStatus('ACCEPTED',$branchcode);
map{$_->{'reasonsloop'}=$reasonsloop;$_->{'date'}=format_date($_->{'date'})} @$accepted_suggestions;
my $rejected_suggestions = &GetSuggestionByStatus('REJECTED',$branchcode);
map{$_->{'reasonsloop'}=$reasonsloop;$_->{'date'}=format_date($_->{'date'})} @$rejected_suggestions;
my $pending_suggestions = &SearchSuggestion("", "", "", "", 'ASKED', "", $branchcode);
map { $_->{'reasonsloop'} = $reasonsloop; $_->{'date'} = format_date($_->{'date'}) } @$pending_suggestions;
my $accepted_suggestions = &GetSuggestionByStatus('ACCEPTED', $branchcode);
map { $_->{'reasonsloop'} = $reasonsloop; $_->{'date'} = format_date($_->{'date'}) } @$accepted_suggestions;
my $rejected_suggestions = &GetSuggestionByStatus('REJECTED', $branchcode);
map { $_->{'reasonsloop'} = $reasonsloop; $_->{'date'} = format_date($_->{'date'}) } @$rejected_suggestions;
# FIXME: BAD use of map in VOID context.
my @allsuggestions;
push @allsuggestions,{"suggestiontype"=>"accepted",
'suggestions_loop'=>$accepted_suggestions,
'reasonsloop' => $reasonsloop};
push @allsuggestions,{"suggestiontype"=>"pending",
'suggestions_loop'=>$pending_suggestions,
'reasonsloop' => $reasonsloop};
push @allsuggestions,{"suggestiontype"=>"rejected",
'suggestions_loop'=>$rejected_suggestions,
'reasonsloop' => $reasonsloop};
push @allsuggestions,
{ "suggestiontype" => "accepted",
'suggestions_loop' => $accepted_suggestions,
'reasonsloop' => $reasonsloop
};
push @allsuggestions,
{ "suggestiontype" => "pending",
'suggestions_loop' => $pending_suggestions,
'reasonsloop' => $reasonsloop
};
push @allsuggestions,
{ "suggestiontype" => "rejected",
'suggestions_loop' => $rejected_suggestions,
'reasonsloop' => $reasonsloop
};
$template->param(
suggestions => \@allsuggestions,
"op_$op" => 1,
dateformat => C4::Context->preference("dateformat"),
suggestions => \@allsuggestions,
"op_$op" => 1,
dateformat => C4::Context->preference("dateformat"),
);
output_html_with_http_headers $input, $cookie, $template->output;