gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 37265: Consideration of UniqueItemFields setting when receiving items in an order 

When using the Koha acquisition module to receive items (basket receiving
an order), Koha does not consideration of UniqueItemFields setting.
The problem is that you can accidentally attach 3 items to an order with the same values.

Test plan:
1. Set preference UniqueItemFields: Public note (itemnotes)
2. Go to the acquisition module.
3. Create a basket with the option for 'Create items when:' set to receiving an order.
4. Add an order to the basket, for example: From a new (empty) record with the Quantity set to 3 or more.
5. Close the basket.
6. Receive the order.
7. Add a public note: TEST, and receive the first item (Add item).
8. You will see that the next item has the same public note.
9. Apply this patch and repeat step 7 - the public note is not used for the next note.

Sponsored-by: kohawbibliotece.pl
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 1b923e946a)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Michał Dudzik 2024-07-08 17:23:45 +02:00 committed by Lucas Gass
parent 7b5cacc6ad
commit bb130a573b
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
acqui/orderreceive.pl
View File

@ -169,15 +169,16 @@ my @gst_values = map {
}, split( '\|', C4::Context->preference("TaxRates") );
$template->param(
freight => $freight,
name => $bookseller->name,
active_currency => $active_currency,
currencies => $currencies->search({ rate => { '!=' => 1 } }),
invoiceincgst => $bookseller->invoiceincgst,
invoiceid => $invoice->{invoiceid},
invoice => $invoice->{invoicenumber},
gst_values => \@gst_values,
vendor => $bookseller,
freight => $freight,
name => $bookseller->name,
active_currency => $active_currency,
currencies => $currencies->search( { rate => { '!=' => 1 } } ),
invoiceincgst => $bookseller->invoiceincgst,
invoiceid => $invoice->{invoiceid},
invoice => $invoice->{invoicenumber},
gst_values => \@gst_values,
vendor => $bookseller,
UniqueItemFields => C4::Context->preference('UniqueItemFields'),
);
my $patron = Koha::Patrons->find( $loggedinuser )->unblessed;