gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 40395: (QA follow-up): Remove unused form 

This form is no longer used. We're now using a single cancellation hold modal and them form resides there, not here on this table
To test on the UI: Apply this patch and ensure cancelling holds works as before, from both pages (tested using borrowernumber 19:
<staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19
<staff_url>/cgi-bin/koha/reserve/request.pl?biblionumber=76&biblionumber=437&biblionumber=77

Fixed the failing test:
prove xt/find-missing-op-in-forms.t

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit ef8e3f6786)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Pedro Amorim 2025-08-21 10:54:28 +00:00 committed by Paul Derscheid
parent ca61730c86
commit bae02837aa
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
1 changed files with 22 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc
View File

@ -143,33 +143,29 @@
[% IF ( CAN_user_circulate_circulate_remaining_permissions ) %]
[% WRAPPER tab_panel tabname="holds" %]
[% IF ( holds_count ) %]
<form action="/cgi-bin/koha/reserve/modrequest.pl" method="post">
[% INCLUDE 'csrf-token.inc' %]
<input type="hidden" name="from" value="circ" />
<table id="holds-table" class="holds_table" style="width: 100% !Important;">
<thead>
<tr>
<th id="checkbox" data-colname="checkbox"><input type="checkbox" class="select_hold_all" /></th>
<th>Hold date</th>
<th class="anti-the">Title</th>
<th>Call number</th>
<th>Item type</th>
<th>Barcode</th>
<th>Pickup at</th>
<th>Expiration</th>
<th>Priority</th>
<th>Notes</th>
<th>Delete?</th>
<th>Suspend?</th>
<th>Status</th>
</tr>
</thead>
</table>
<table id="holds-table" class="holds_table" style="width: 100% !Important;">
<thead>
<tr>
<th id="checkbox" data-colname="checkbox"><input type="checkbox" class="select_hold_all" /></th>
<th>Hold date</th>
<th class="anti-the">Title</th>
<th>Call number</th>
<th>Item type</th>
<th>Barcode</th>
<th>Pickup at</th>
<th>Expiration</th>
<th>Priority</th>
<th>Notes</th>
<th>Delete?</th>
<th>Suspend?</th>
<th>Status</th>
</tr>
</thead>
</table>
<fieldset class="action">
<button class="btn btn-primary cancel_selected_holds" data-bulk="true"></button>
</fieldset>
</form>
<fieldset class="action">
<button class="btn btn-primary cancel_selected_holds" data-bulk="true"></button>
</fieldset>
[% PROCESS 'cancel-hold-modal' form_action = '/cgi-bin/koha/reserve/modrequest.pl' from_param = patronpage %]
[% PROCESS 'suspend-hold-modal' %]