gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 37651: (follow-up) Add GetAvailability test case for future hold 

Test plan:
Run t/db_dependent/ILSDI_Services.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 2ebd1e379e)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Marcel de Rooy 2025-07-21 16:02:49 +02:00 committed by Paul Derscheid
parent 3f8ca7c7b2
commit ba16aa352e
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
1 changed files with 46 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
t/db_dependent/ILSDI_Services.t
View File

@ -20,7 +20,7 @@ use Modern::Perl;
use CGI qw ( -utf8 );
use Test::NoWarnings;
use Test::More tests => 15;
use Test::More tests => 16;
use Test::MockModule;
use t::lib::Mocks;
use t::lib::TestBuilder;
@ -1147,6 +1147,51 @@ subtest 'GetAvailability itemcallnumber' => sub {
$schema->storage->txn_rollback;
};
subtest 'GetAvailability availabilitystatus' => sub {
plan tests => 4;
$schema->storage->txn_begin;
my $item = $builder->build_sample_item;
my ( $cgi, $reply, $xml, $status, $message );
$cgi = CGI->new;
$cgi->param( service => 'GetAvailability' );
$cgi->param( id => $item->biblionumber );
$cgi->param( id_type => 'biblio' );
$reply = C4::ILSDI::Services::GetAvailability($cgi);
$xml = XML::LibXML->load_xml( string => $reply );
$status = $xml->findnodes('//dlf:availabilitystatus')->to_literal();
is( $status, 'available', 'GetAvailability returns available' );
my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
$patron->branchcode( $item->holdingbranch )->store;
AddReserve(
{
reservation_date => dt_from_string()->add( days => 1 ),
branchcode => $item->holdingbranch,
borrowernumber => $patron->id,
biblionumber => $item->biblionumber,
itemnumber => $item->itemnumber,
}
);
t::lib::Mocks::mock_preference( 'ConfirmFutureHolds', 0 );
$reply = C4::ILSDI::Services::GetAvailability($cgi);
$xml = XML::LibXML->load_xml( string => $reply );
$status = $xml->findnodes('//dlf:availabilitystatus')->to_literal();
is( $status, 'available', 'GetAvailability returns available, ignoring future hold' );
t::lib::Mocks::mock_preference( 'ConfirmFutureHolds', 2 );
$reply = C4::ILSDI::Services::GetAvailability($cgi);
$xml = XML::LibXML->load_xml( string => $reply );
$status = $xml->findnodes('//dlf:availabilitystatus')->to_literal();
$message = $xml->findnodes('//dlf:availabilitymsg')->to_literal();
is( $status, 'not available', 'GetAvailability returns not available status for future hold' );
is( $message, 'On hold', 'GetAvailability returns on hold message for future hold' );
t::lib::Mocks::mock_preference( 'ConfirmFutureHolds', 0 );
$schema->storage->txn_rollback;
};
subtest 'Bug 34893: ILS-DI can return the wrong patron for AuthenticatePatron' => sub {
plan tests => 2;