From b93dafbb9efb15c6494e8eb65d77f3994e7aa424 Mon Sep 17 00:00:00 2001
From: Lucas Gass <lucas@bywatersolutions.com>
Date: Fri, 19 Sep 2025 17:22:53 +0000
Subject: [PATCH] Bug 40843: Sort patron attributes by description

To test:

1/ Have several borrower attributes set up so you can see how they sort
2/ Go to Tools >  Batch patron modification
3/ Notice the "Patron attribute:: dropdown near the bottom
4/ It is sorted by the attribute code, not the description.
5/ APPLY PATCH and restart_all
6/ Try again, it should sort by the description

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 29f95187859ab21bb7ca67f48173e4317f5121f0)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
(cherry picked from commit c63b49d8d0558218173732930ef79beb5646a69d)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 tools/modborrowers.pl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl
index 9e1830ddb2..97ce922a53 100755
--- a/tools/modborrowers.pl
+++ b/tools/modborrowers.pl
@@ -175,6 +175,7 @@ if ( $op eq 'cud-show' || $op eq 'show' ) {
             category_lib   => $category_lib,
             type           => $attr_type->authorised_value_category ? 'select' : 'text',
             };
+        @patron_attributes_codes = sort { $a->{attribute_lib} cmp $b->{attribute_lib} } @patron_attributes_codes;
     }
 
     my @attributes_header = ();