From b64fc2ecd7835dcc7bfc339de2e887dc3fdde40c Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Tue, 25 Mar 2025 15:41:08 +0000 Subject: [PATCH] Bug 39449: Fix table sort arrows Test plan: 1) Look at the same biblio on both OPAC and Staff: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=76 2) Click on the 'current library' column header for OPAC and 'Home library' for staff. Notice that on Staff when it's DESC, arrow points down (as expected), but on OPAC when it's DESC, the arrows points up. 3) Apply patch. Reset CSS: yarn css:build 4) Do a hard refresh on the OPAC. Repeat test plan. Notice they now behave the same. Signed-off-by: Owen Leonard Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer (cherry picked from commit 1d6017bbd8e8e54151cf2c787fbfeaf022f08f1c) Signed-off-by: Fridolin Somers --- .../opac-tmpl/bootstrap/css/src/_common.scss | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss index 0f9516bd00..b290d8c788 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss +++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss @@ -579,12 +579,6 @@ table { line-height: .5rem; } - &.dt-ordering-asc span.dt-column-order::before - &.dt-ordering-desc span.dt-column-order::after { - color: #006100; - opacity: 1; - } - &.dt-orderable-asc span.dt-column-order::before, &.dt-ordering-asc span.dt-column-order::before { content: "\f0d8"; /* fa-cart-up */ @@ -619,12 +613,6 @@ table { } } - - &.dt-ordering-asc span.dt-column-order::after, - &.dt-ordering-desc span.dt-column-order::before { - opacity: 1; - } - &.dt-ordering-asc span.dt-column-order::before, &.dt-ordering-desc span.dt-column-order::after { opacity: .2; @@ -638,6 +626,12 @@ table { &:active { outline: none; } + + &.dt-ordering-asc span.dt-column-order::before, + &.dt-ordering-desc span.dt-column-order::after { + color: #006100; + opacity: 1; + } } } }