gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices 

1. Turn on EmailPurchaseSuggestions and add an email address to EmailAddressForSuggestions.
2. Create a new suggestion and set the "
Created by:" field to a patron with an email address
3. Check the message queue ( select * from message_queue where letter_code = "NEW_SUGGESTION" )
4. There is a NEW_SUGGESTION queued, the to_address should be the email you entered in EmailAddressForSuggestions.
5. The borrowernumber is the borrower who made the suggestion.
6. APPLY PATCH, restart_all
7. Repeat steps 2 - 4.
8. This time a NEW_SUGGESTION should be queued, but the borrowernumber will be undef
9. Check in the patron's notice tab, there should be nothing queued.

Signed-off-by: Lin Wei Li <lin-wei.li@inLibro.com>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 6b6d9f275e)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Lucas Gass 2025-05-12 21:53:45 +00:00 committed by Paul Derscheid
parent 59897c7dcb
commit b394efcd90
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Koha/Suggestion.pm
View File

@ -110,10 +110,10 @@ sub store {
C4::Letters::EnqueueLetter(
{
letter => $letter,
borrowernumber => $result->suggestedby,
suggestionid => $result->id,
to_address => $toaddress,
letter => $letter,
borrowernumber => undef, #NEW_SUGGESION notices should not end up in the borrowers notice tab
suggestionid => $result->id,
to_address => $toaddress,
message_transport_type => 'email',
}
) or warn "can't enqueue letter $letter";