From b369ba5d17550a02241e3e2dcf40973ebb10b630 Mon Sep 17 00:00:00 2001
From: Lucas Gass <lucas@bywatersolutions.com>
Date: Wed, 9 Sep 2026 13:59:37 +0000
Subject: [PATCH] Bug 36868: Move array splice in OPAC js to after the -1 check

Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
---
 koha-tmpl/opac-tmpl/bootstrap/js/basket.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/basket.js b/koha-tmpl/opac-tmpl/bootstrap/js/basket.js
index fa795b8729..ad045ee02a 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/js/basket.js
+++ b/koha-tmpl/opac-tmpl/bootstrap/js/basket.js
@@ -234,13 +234,13 @@ function delSingleRecord(biblionumber) {
     var valCookie = readCookie(nameCookie);
     var arrayRecords = valCookie.split("/");
     var pos = jQuery.inArray(biblionumber, arrayRecords);
-    arrayRecords.splice(pos, 1);
 
     // if pos is -1, the cart is empty, bail
     if (pos === -1) {
         return;
     }
 
+    arrayRecords.splice(pos, 1);
     valCookie = arrayRecords.join("/");
     writeCookie(nameCookie, valCookie);
     updateBasket(arrayRecords.length - 1);