Follow up on Bug 5462: fixing variable names breaks messaging preference form
The messaging prefs form was hardcoded to use 'transport-$transport_type', rather than 'transport_$transport_type'. The result was an uneditable messaging preferences form. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This commit is contained in:
parent
6709d0e4f7
commit
b2c56dfe62
|
|
@ -132,7 +132,7 @@ sub set_form_values {
|
|||
} ( 0..30 ); # FIXME: 30 is a magic number.
|
||||
}
|
||||
foreach my $transport ( @{$pref->{'transports'}} ) {
|
||||
$option->{'transport-'.$transport} = 'checked="checked"';
|
||||
$option->{'transport_'.$transport} = 'checked="checked"';
|
||||
}
|
||||
$option->{'digest'} = 'checked="checked"' if $pref->{'wants_digest'};
|
||||
}
|
||||
|
|
|
|||
|
|
@ -213,7 +213,7 @@ END_SQL
|
|||
$choices->{ $row->{'message_name'} }->{'message_name'} = $row->{'message_name'};
|
||||
$choices->{ $row->{'message_name'} }->{'takes_days'} = $row->{'takes_days'};
|
||||
$choices->{ $row->{'message_name'} }->{'has_digest'} = 1 if $row->{'is_digest'};
|
||||
$choices->{ $row->{'message_name'} }->{'transport-' . $row->{'message_transport_type'}} = ' ';
|
||||
$choices->{ $row->{'message_name'} }->{'transport_' . $row->{'message_transport_type'}} = ' ';
|
||||
}
|
||||
|
||||
my @return = values %$choices;
|
||||
|
|
|
|||
Loading…
Reference in New Issue