gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 39917: (QA follow-up) Correct spelling and remove <p> tag around form 

QA tools complained

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit d2f007320a)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Nick Clemens 2025-08-01 16:08:06 +00:00 committed by Paul Derscheid
parent 45cde551d9
commit b13602054f
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
2 changed files with 18 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
View File

@ -121,25 +121,23 @@
<h1>Complete ILL request</h1>
<p>Proceeding with this action will set this request to 'Completed'.</p>
<p>You can select a status alias from the available options:</p>
<p>
[% base_url = "/cgi-bin/koha/ill/ill-requests.pl" %]
[% proceed_url = base_url _ "?method=mark_completed&stage=complete" _ "&illrequest_id=" _ request.illrequest_id %]
<form action="[% proceed_url | url %]" method="get">
<select name="status_alias">
<option value="" selected></option>
[% FOREACH alias IN AuthorisedValues.Get('ILL_STATUS_ALIAS') %]
<option value="[% alias.authorised_value | html %]" > [% alias.lib | html %] </option>
[% END %]
</select>
<input type="hidden" name="method" value="mark_completed">
<input type="hidden" name="stage" value="complete">
<input type="hidden" name="illrequest_id" value="[% request.illrequest_id | html%]">
<fieldset class="action">
<button type="submit" class="btn btn-sm btn-primary">Complete request</button>
<a class="btn btn-sm btn-default cancel" href="[% base_url | url %]">Cancel</a>
</fieldset>
</form>
</p>
[% base_url = "/cgi-bin/koha/ill/ill-requests.pl" %]
[% proceed_url = base_url _ "?method=mark_completed&stage=complete" _ "&illrequest_id=" _ request.illrequest_id %]
<form action="[% proceed_url | url %]" method="get">
<select name="status_alias">
<option value="" selected></option>
[% FOREACH alias IN AuthorisedValues.Get('ILL_STATUS_ALIAS') %]
<option value="[% alias.authorised_value | html %]"> [% alias.lib | html %] </option>
[% END %]
</select>
<input type="hidden" name="method" value="mark_completed" />
<input type="hidden" name="stage" value="complete" />
<input type="hidden" name="illrequest_id" value="[% request.illrequest_id | html %]" />
<fieldset class="action">
<button type="submit" class="btn btn-sm btn-primary">Complete request</button>
<a class="btn btn-sm btn-default cancel" href="[% base_url | url %]">Cancel</a>
</fieldset>
</form>
[% ELSIF op == 'cud-cancel' and !whole.error %]
<h1>Cancel a confirmed request</h1>
[% PROCESS $whole.template %]

2
t/db_dependent/Koha/ILL/Requests.t
View File

@ -194,7 +194,7 @@ subtest 'Basic object tests' => sub {
isnt(
$illrq_obj->status, 'COMP',
"ILL_STATUS_ALIAS is not empty. ILL is not immediatelly complete."
"ILL_STATUS_ALIAS is not empty. ILL is not immediately complete."
);
is(