gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 35044: (QA follow-up): Allow for '0' in serials batch edit 

This commit also ensures any existing '0' value additional fields are
kept if batch editing and submitting the input empty

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Pedro Amorim 2024-07-25 16:39:00 +00:00 committed by Katrin Fischer
parent a1ed1035ad
commit afe1d0a4c6
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Koha/Object/Mixin/AdditionalFields.pm
View File

@ -150,7 +150,7 @@ sub add_additional_fields {
push @additional_fields, {
id => $field->id,
value => $value,
} if $value;
} if defined $value && $value ne '';
}
} else {
my $existing_additional_field_values = $self->additional_field_values->search( { field_id => $field->id } );
@ -158,7 +158,7 @@ sub add_additional_fields {
push @additional_fields, {
id => $field->id,
value => $existing->value,
} if $existing && $existing->value;
} if $existing && defined $existing->value && $existing->value ne '';
}
}
}

2
serials/subscription-batchedit.pl
View File

@ -72,7 +72,7 @@ if ( $op eq 'cud-batchedit' ) {
my @submitted_fields_array;
foreach my $submitted_field (@submitted_fields) {
push @submitted_fields_array, $submitted_field if $submitted_field;
push @submitted_fields_array, $submitted_field if defined $submitted_field && $submitted_field ne '';
}
$field_values->{ $available_field->id } = \@submitted_fields_array;
}