From aed4eb5974348d2560be21b300ee189a966c0d34 Mon Sep 17 00:00:00 2001
From: Lucas Gass <lucas@bywatersolutions.com>
Date: Tue, 11 Feb 2025 21:27:14 +0000
Subject: [PATCH] Bug 38939: Add reservenote column to members/holdshistory.pl

To test:
1. APPLY PATCH, restart_all
2. Make some holds for patrons in both the staff client and the OPAC. ( For OPAC turn on  OpacHoldNotes )
3. Make sure you add some notes to each of these holds.
4. Go to the patron account and click on the 'Holds history' tab.
5. Make sure the hold note is there and looks correct.
6. Ensure you can hide the coluimn properly via Table settings.

Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 81859ce66292170af79d41905fe93127932984d1)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
---
 admin/columns_settings.yml                             |  2 ++
 .../prog/en/modules/members/holdshistory.tt            | 10 ++++++++++
 2 files changed, 12 insertions(+)

diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml
index d9759f8f83..836367db46 100644
--- a/admin/columns_settings.yml
+++ b/admin/columns_settings.yml
@@ -1447,6 +1447,8 @@ modules:
               columnname: itemtype
             -
               columnname: status
+            -
+              columnname: notes
 
     checkouthistory:
       checkouthistory-table:
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt
index 970bd4d4ad..b1a4735c59 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt
@@ -97,6 +97,7 @@
                                 <th>Requested item type</th>
                             [% END %]
                             <th>Status</th>
+                            <th>Notes</th>
                         </tr>
                     </thead>
                 </table>
@@ -141,6 +142,7 @@
                                 <th>Requested item type</th>
                             [% END %]
                             <th>Status</th>
+                            <th>Notes</th>
                         </tr>
                     </thead>
                 </table>
@@ -332,6 +334,14 @@
                                 return _("Pending");
                             }
                         },
+                        {
+                            data: "notes",
+                            searchable: true,
+                            orderable: true,
+                            render: function (data, type, row, meta) {
+                                return row.notes;
+                            }
+                        },
                     ],
                 }, table_settings, true, additional_filters);
             }