gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 25709: Rename systempreference to NotesToHide 

In an effort to use more inclusive language we have added a new coding guideline:
https://wiki.koha-community.org/wiki/Coding_Guidelines#TERM3:_Inclusive_Language

This patchset renames a syspref to be clearer and follow the guideline

To test:
1 - Apply patch and updatedatabase
2 - git grep NotesBlacklist
3 - Note all remaining occurrences are translations, db updates, and release notes
4 - Add a field (e.g. '520' ) to the NotesToHide systempreference
5 - View a record with a 520 field on the opac
6 - Confirm the field does not show in the 'Title notes' tab

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 5e45076c00)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit f00ce94d94)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
This commit is contained in:
Nick Clemens 2020-07-06 17:56:35 +00:00 committed by Aleisha Amohia
parent fa08592991
commit aeb39a61bd
5 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
C4/Biblio.pm
View File

@ -1519,11 +1519,11 @@ sub GetMarcNotes {
590 => 1
);
my %blacklist = map { $_ => 1 }
split( /,/, C4::Context->preference('NotesBlacklist'));
my %hiddenlist = map { $_ => 1 }
split( /,/, C4::Context->preference('NotesToHide'));
foreach my $field ( $record->field($scope) ) {
my $tag = $field->tag();
next if $blacklist{ $tag };
next if $hiddenlist{ $tag };
next if $opac && $maybe_private{$tag} && !$field->indicator(1);
if( $marcflavour ne 'UNIMARC' && $field->subfield('u') ) {
# Field 5XX$u always contains URI

6
installer/data/mysql/atomicupdate/rename_preference_NotesToHide.perl Normal file
View File

@ -0,0 +1,6 @@
$DBversion = 'XXX'; # will be replaced by the RM
if( CheckVersion( $DBversion ) ) {
$dbh->do( "UPDATE systempreferences SET variable='NotesToHide' WHERE variable = 'NotesBlacklist'" );
print "Bug 25709: Rename systempreference to NotesToHide\n";
SetVersion( $DBversion );
}

2
installer/data/mysql/sysprefs.sql
View File

@ -328,7 +328,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
('NoIssuesChargeGuarantees','','','Define maximum amount withstanding before check outs are blocked','Integer'),
('noItemTypeImages','0',NULL,'If ON, disables item-type images','YesNo'),
('NoRenewalBeforePrecision','exact_time','date|exact_time','Calculate "No renewal before" based on date only or exact time of due date','Choice'),
('NotesBlacklist','',NULL,'List of notes fields that should not appear in the title notes/description separator of details','free'),
('NotesToHide','',NULL,'List of notes fields that should not appear in the title notes/description separator of details','free'),
('NotHighlightedWords','and|or|not',NULL,'List of words to NOT highlight when OpacHitHighlight is enabled','free'),
('NoticeBcc','','','Email address to bcc outgoing notices sent by email','free'),
('NoticeCSS','',NULL,'Notices CSS url.','free'),

2
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
View File

@ -230,7 +230,7 @@ Cataloging:
- "is the logged in user's library. The second tab will contain all other items."
-
- "Don't show"
- pref: NotesBlacklist
- pref: NotesToHide
class: multi
- "note fields in the 'Title notes' tab and in the 'Description' tab on the OPAC and staff interface detail pages. Use a comma to separate multiple fields. Examples: 500,502 (MARC21); 300,328 (UNIMARC)."
- <br />

4
t/Biblio/GetMarcNotes.t
View File

@ -27,7 +27,7 @@ use C4::Biblio;
subtest 'GetMarcNotes MARC21' => sub {
plan tests => 11;
t::lib::Mocks::mock_preference( 'NotesBlacklist', '520' );
t::lib::Mocks::mock_preference( 'NotesToHide', '520' );
my $record = MARC::Record->new;
$record->append_fields(
@ -55,7 +55,7 @@ subtest 'GetMarcNotes MARC21' => sub {
subtest 'GetMarcNotes UNIMARC' => sub {
plan tests => 3;
t::lib::Mocks::mock_preference( 'NotesBlacklist', '310' );
t::lib::Mocks::mock_preference( 'NotesToHide', '310' );
my $record = MARC::Record->new;
$record->append_fields(