gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 40981: Prevent KohaTable/Holdings_spec.ts to fail randomly 

There is a JS warning raised by DT which makes the tests fail:
```
The following error originated from your application code, not from Cypress.

  > DataTables warning detected in log: "DataTables warning: table id=holdings_table - Ajax error. For more information about this error, please see https://datatables.net/tn/7"
```

It is caused by a 404 returned by the API, because DT receives the
response during the afterEach (after the objects have been deleted)

We must wait for the responses when needed.

Test plan:
  cypress run --spec t/cypress/integration/KohaTable/Holdings_spec.ts
should still pass

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit de85f171fd)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Jonathan Druart 2025-10-09 11:31:26 +02:00 committed by Paul Derscheid
parent 0fa5eb583b
commit a9bc9c79ce
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
t/cypress/integration/KohaTable/Holdings_spec.ts
View File

@ -34,11 +34,18 @@ describe("catalogue/detail/holdings_table with items", () => {
it("Correctly init the table", function () {
// Do not use `() => {` or this.objects won't be retrieved
const biblio_id = this.objects.biblio.biblio_id;
cy.intercept("get", `/api/v1/biblios/${biblio_id}/items*`).as(
"searchItems"
);
cy.set_syspref("AlwaysShowHoldingsTableFilters", 1).then(() => {
cy.visit(
"/cgi-bin/koha/catalogue/detail.pl?biblionumber=" + biblio_id
);
cy.wait("@searchItems");
cy.get(`#${table_id}_wrapper tbody tr`).should(
"have.length",
RESTdefaultPageSize
@ -54,6 +61,10 @@ describe("catalogue/detail/holdings_table with items", () => {
// Do not use `() => {` or this.objects won't be retrieved
const biblio_id = this.objects.biblio.biblio_id;
cy.intercept("get", `/api/v1/biblios/${biblio_id}/items*`).as(
"searchItems"
);
cy.set_syspref("AlwaysShowHoldingsTableFilters", 0).then(() => {
cy.visit(
"/cgi-bin/koha/catalogue/detail.pl?biblionumber=" + biblio_id
@ -67,6 +78,8 @@ describe("catalogue/detail/holdings_table with items", () => {
"items_table_settings.holdings"
);
cy.wait("@searchItems");
cy.get("@columns").then(columns => {
cy.get(`#${table_id}_wrapper tbody tr`).should(
"have.length",
@ -83,6 +96,7 @@ describe("catalogue/detail/holdings_table with items", () => {
.should("not.exist");
cy.get(`.${table_id}_table_controls .show_filters`).click();
cy.wait("@searchItems");
cy.get(`#${table_id}_wrapper .dt-info`).contains(
`Showing 1 to ${RESTdefaultPageSize} of ${baseTotalCount} entries`
);
@ -110,6 +124,8 @@ describe("catalogue/detail/holdings_table with items", () => {
"items_table_settings.holdings"
);
cy.wait("@searchItems");
cy.get("@columns").then(columns => {
cy.get(`#${table_id}_wrapper tbody tr`).should(
"have.length",
@ -120,6 +136,7 @@ describe("catalogue/detail/holdings_table with items", () => {
cy.get(`#${table_id} thead tr`).should("have.length", 2);
cy.get(`.${table_id}_table_controls .hide_filters`).click();
cy.wait("@searchItems");
// Filters are not displayed
cy.get(`#${table_id} thead tr`).should("have.length", 1);
@ -290,8 +307,15 @@ describe("catalogue/detail/holdings_table without items", () => {
// Do not use `() => {` or this.objects won't be retrieved
const biblio_id = this.objects.biblio.biblio_id;
cy.intercept("get", `/api/v1/biblios/${biblio_id}/items*`).as(
"searchItems"
);
cy.visit("/cgi-bin/koha/catalogue/detail.pl?biblionumber=" + biblio_id);
// No API request
cy.get("@searchItems.all").should("have.length", 0);
cy.get(`#${table_id}_wrapper`).should("not.exist");
});
});